Add the ability to reply asynchronously to a ResendRequest #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artio-system-tests/src/test/java/uk/co/real_logic/artio/util/DebugServer.java
Show resolved
Hide resolved
artio-system-tests/src/test/java/uk/co/real_logic/artio/util/DebugServer.java
Show resolved
Hide resolved
artio-system-tests/src/test/java/uk/co/real_logic/artio/util/DebugFIXClient.java
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #503
When using an asynchronous SessionProxy and an external cluster, if we detect a gap when receiving a Logon message, and the Logon message is immediately followed by a ResendRequest (i.e. the other party also detected a gap), then we want to make sure that we process the received ResendRequest only after we effectively sent our own.
It is not currently possible, and as a consequence the replayer on engine side can send a SequenceReset/GapFill faster than the ResendRequest. This generates a "MsgSeqNum too low" error on the other side.
This PR allows to use SessionProxy to indicate that the ResendRequest processing must be delayed, so the Session will not do anything. When the SessionProxy is ready, it can asynchronously trigger the processing of the ResendRequest.