Skip to content

Conversation

@SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Nov 9, 2025

1228 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:196:69: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:609:40: Warning: @escaping attribute not required as 'action' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:872:41: Warning: @escaping attribute not required as 'multipartFormData' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:922:41: Warning: @escaping attribute not required as 'multipartFormData' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1137:51: Warning: @escaping attribute not required as 'shouldCreateTask' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1325:62: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:193:31: Warning: @escaping attribute not required as 'monitor' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:236:31: Warning: @escaping attribute not required as 'monitor' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/CachedResponseHandler.swift:80:38: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/SessionDelegate.swift:89:45: Warning: @escaping attribute not required as 'completionHandler' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/SessionDelegate.swift:180:63: Warning: @escaping attribute not required as 'completionHandler' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RequestInterceptor.swift:123:83: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RequestInterceptor.swift:131:35: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:767:73: Warning: @escaping attribute not required as 'closure' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:784:71: Warning: @escaping attribute not required as 'closure' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RetryPolicy.swift:311:33: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RedirectHandler.swift:84:34: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RequestCompression.swift:70:83: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/RequestInterceptorTests.swift:683:76: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/RequestInterceptorTests.swift:695:94: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/DataStreamTests.swift:910:84: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/DataStreamTests.swift:918:102: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:43:92: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:70:92: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:130:32: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:165:32: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:213:32: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:232:32: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:1618:36: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:1765:84: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:1775:102: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:131:80: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/ShortcutsWidget.swift:41:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/ShortcutsWidget.swift:65:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/SingleStatWidget.swift:48:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/SingleStatWidget.swift:60:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/TopNewsWidget.swift:82:53: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/LockScreenShortcutWidget.swift:47:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/LockScreenShortcutWidget.swift:58:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/StatsWidget.swift:39:53: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/StatsWidget.swift:43:53: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/TopNewsListWidget.swift:48:53: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/iOS/Delegates/SceneDelegate.swift:256:24: Warning: @escaping attribute not required as 'completionHandler' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/ClientTests/User Scripts/MockMessageHandler.swift:35:19: Warning: @escaping attribute not required as 'replyHandler' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/ClientTests/User Scripts/MockScriptsViewController.swift:146:22: Warning: @escaping attribute not required as 'decisionHandler' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveVPN/Components/InstallVPN/BraveVPNInstallViewController.swift:139:65: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource.swift:963:66: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/KeyringStore.swift:395:57: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Search/TokenList.swift:43:26: Warning: @escaping attribute not required as 'header' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Search/TokenList.swift:44:34: Warning: @escaping attribute not required as 'emptyStateView' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Search/TokenList.swift:91:34: Warning: @escaping attribute not required as 'emptyStateView' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Search/TokenList.swift:108:26: Warning: @escaping attribute not required as 'header' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:142:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:155:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:167:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:175:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:183:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:191:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:202:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:210:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:215:41: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:219:37: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:226:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBlockchainRegistry.swift:234:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockSwapService.swift:14:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockSwapService.swift:19:53: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockSwapService.swift:25:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockSwapService.swift:45:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:38:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:51:54: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:57:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:66:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:78:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:89:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockAssetRatioService.swift:97:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:17:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:28:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:37:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:46:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:54:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:62:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:72:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:79:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:86:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:93:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:103:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:114:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:121:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockEthTxManagerProxy.swift:129:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:22:42: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:29:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:34:34: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:39:69: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:43:72: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:50:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:62:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:67:36: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:74:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:82:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:87:33: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:92:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:98:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:103:40: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:111:46: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:121:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:128:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:136:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:172:35: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:191:45: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:195:35: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:203:70: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:209:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:214:70: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:218:63: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:224:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:229:71: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:237:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:243:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:257:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:269:58: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:273:67: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:280:42: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:284:40: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:288:41: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:301:40: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:308:42: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:312:36: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:318:72: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Preview Content/MockBraveWalletService.swift:325:17: Warning: @escaping attribute not required as 'completion' does not escape (unneeded_escaping)
⚠️ Danger found 1228 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 130.
18 Messages
📖 Building this branch resulted in a binary size of 26758.79 KiB vs 26711.91 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.73 s vs 0.73 s on main (0% slower).
📖 Linting Alamofire with this PR took 1.01 s vs 1.0 s on main (1% slower).
📖 Linting Brave with this PR took 6.74 s vs 6.69 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 21.23 s vs 21.17 s on main (0% slower).
📖 Linting Firefox with this PR took 10.78 s vs 10.71 s on main (0% slower).
📖 Linting Kickstarter with this PR took 7.49 s vs 7.44 s on main (0% slower).
📖 Linting Moya with this PR took 0.44 s vs 0.42 s on main (4% slower).
📖 Linting NetNewsWire with this PR took 2.34 s vs 2.28 s on main (2% slower).
📖 Linting Nimble with this PR took 0.61 s vs 0.61 s on main (0% slower).
📖 Linting PocketCasts with this PR took 6.82 s vs 6.79 s on main (0% slower).
📖 Linting Quick with this PR took 0.41 s vs 0.37 s on main (10% slower).
📖 Linting Realm with this PR took 3.21 s vs 3.22 s on main (0% faster).
📖 Linting Sourcery with this PR took 1.72 s vs 1.76 s on main (2% faster).
📖 Linting Swift with this PR took 4.13 s vs 4.11 s on main (0% slower).
📖 Linting VLC with this PR took 1.08 s vs 1.08 s on main (0% slower).
📖 Linting Wire with this PR took 17.14 s vs 17.1 s on main (0% slower).
📖 Linting WordPress with this PR took 11.18 s vs 11.14 s on main (0% slower).

Here's an example of your CHANGELOG entry:

* Add new `unneeded_escaping` rule.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants