Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3.1] [Bug] importing anything from the library results in error - Keys is not a function #265

Closed
himanshu-1034 opened this issue Nov 26, 2024 · 11 comments
Assignees

Comments

@himanshu-1034
Copy link

himanshu-1034 commented Nov 26, 2024

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X ] Bug report 
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Issue occurs as soon as you import anything from library version 5.3.1
image

Expected behavior

Normally, the error should not come. So far we were using version 5.1.0 which did not cause any issue with our project. recently there was a requirement which could be easily resolved by a function exposed in latest version of this library (fitNodes) but due to this error we cannot upgrade the library.
Any help provided will be appreciated

Minimal reproduction of the problem with instructions

Step 1 -> Setup a react project with following library versions ->

  • React@18
  • React-dom@18
  • React-scripts@5
    Step 2 -> Install [email protected] and simply import Canvas component exposed by this library.
    Step 3 -> Run the server and you will see an error on console

What is the motivation / use case for changing the behavior?

Environment


Libs:
- react version: 18.0.0
- react-dom: 18.0.0
- react-scripts: 5.0.0
- reaflow: 5.3.1


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
- [ x] All Browsers
 
For Tooling issues:
- Node version: have tried with v15, v18, v22
- Platform:  Mac
- IDE: VS code and Codesandbox env as well

Others:

@himanshu-1034 himanshu-1034 changed the title [5.3.1] [Bug] importing anything from the library results in error - Keys is not defined [5.3.1] [Bug] importing anything from the library results in error - Keys is not a function Nov 26, 2024
@himanshu-1034
Copy link
Author

Anyone who can help here?

@amcdnl amcdnl assigned evgenoid and SerhiiTsybulskyi and unassigned evgenoid Dec 2, 2024
@evgenoid evgenoid assigned evgenoid and unassigned SerhiiTsybulskyi Dec 5, 2024
@AykutSarac
Copy link
Contributor

AykutSarac commented Dec 24, 2024

I tried to upgrade from 5.2.8 to 5.3.1 and getting this error at the moment, flow diagram is not rendering.
EDIT: Issue starts from the version 5.2.12

@evgenoid
Copy link
Contributor

evgenoid commented Jan 7, 2025

@AykutSarac @himanshu-1034 I'll take a look. Now I can reproduce it:
Screenshot 2025-01-07 at 16 07 53

@AykutSarac
Copy link
Contributor

Library is unusable at the moment, is there a progress?

@amcdnl
Copy link
Member

amcdnl commented Jan 27, 2025

@AykutSarac - Is it just related to NextJS or is this with anything?

@AykutSarac
Copy link
Contributor

I only tried on NextJS, but since OP didn't mention it I think that's a problem in general with React.

@SerhiiTsybulskyi
Copy link
Contributor

I tried your code box sample on the latest versions of different browsers (Chrome, Safari, Edge, Firefox) but couldn't reproduce it.

Image

There is my sample on NextJS also working.

Image

@AykutSarac Can you give me more detail about your environment?

@AykutSarac
Copy link
Contributor

That's the project: https://github.com/AykutSarac/jsoncrack.com

@SerhiiTsybulskyi
Copy link
Contributor

@AykutSarac The fix of the issue was released in v5.3.4.
Please try updating the version and let us know if the problem has gone away.

@AykutSarac
Copy link
Contributor

It seems to be resolved, thank you!

@SerhiiTsybulskyi
Copy link
Contributor

Fixed with reaviz/reakeys#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants