Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Item name with ItemType #274

Open
Eraden opened this issue Jan 1, 2023 · 0 comments
Open

Replace Item name with ItemType #274

Eraden opened this issue Jan 1, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Eraden
Copy link
Contributor

Eraden commented Jan 1, 2023

There's limited amount of items and they can be identified with enum, name can be retrieved when needed

This should also reduce code noise.

I suggest to create solution similar to Machine solution:

#[derive(Debug, Copy, Clone, serde::Serialize, serde::Deserialize)]
pub enum ItemType {
    SuperGlue = 0,
    Petrol = 1,
    // ...
}

impl ItemType {
    pub fn t(self, lng: Lang) -> 'static str {
        item_names(lng)[self as usize]
    }
}
@Nereuxofficial Nereuxofficial added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants