Added Virtual network autocreation during Virual machine with public IP creation

Author: anna-savina

changelogs/fragments/20240602-azure_vm_with_public_ip_create.yml

@@ -0,0 +1,3 @@
+bugfixes:
+  - Added Virtual network autocreation during Virual machine with public IP creation
+    in case Virtual network doesn't exist for azure_virtual_machine_with_public_ip role

roles/azure_virtual_machine_with_public_ip/tasks/create.yml

@@ -32,7 +32,7 @@
     azure_manage_resource_group_tags: "{{ azure_virtual_machine_with_public_ip_tags | default(omit) }}"
   when: rg_info.resourcegroups | length == 0
 
-# If nic is not specified, assert virtual network exists and create default public ip & nic
+# If nic is not specified, create virtual network if needed and create default public ip & nic
 - name: Ensure default nic and default public ip
   when: azure_virtual_machine_with_public_ip_vm.network_interfaces is undefined
   block:
@@ -41,10 +41,30 @@
         resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
       register: vnet_info
 
-    - name: Ensure vnet exists
-      ansible.builtin.fail:
-        msg: When no network interfaces are specified, a virtual network must exist
-      when: vnet_info.virtualnetworks | length == 0
+    - name: Specify either create a virtual network or to use existen
+      ansible.builtin.set_fact:
+        vnet_autocreated: "{{ vnet_info.virtualnetworks | length == 0 }}"
+
+    - name: Ensure virtual network exists
+      when: vnet_autocreated
+      block:
+        - name: No virtual network exists -> create virtual network and subnet
+          ansible.builtin.include_role:
+            name: cloud.azure_ops.azure_manage_networking_stack
+          vars:
+            azure_manage_networking_stack_operation: create
+            azure_manage_networking_stack_resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+            azure_manage_networking_stack_virtual_network: "{{ vm_name }}"
+            azure_manage_networking_stack_subnet: "{{ vm_name }}"
+            azure_manage_networking_stack_vnet_address_prefixes_cidr:
+            - "10.1.0.0/16"
+            azure_manage_networking_stack_subnet_address_prefixes_cidr:
+            - "10.1.0.0/24"
+
+        - name: Refresh virtual network info
+          azure.azcollection.azure_rm_virtualnetwork_info:
+            resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+          register: vnet_info
 
     - name: Create default public ip for default nic
       azure.azcollection.azure_rm_publicipaddress:

roles/azure_virtual_machine_with_public_ip/tasks/delete.yml

@@ -11,6 +11,15 @@
     remove_on_absent: "{{ azure_virtual_machine_with_public_ip_remove_on_absent | default(omit) }}"
     state: absent
 
+- name: Delete Virtual network if requested
+  azure.azcollection.azure_rm_virtualnetwork:
+    resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+    name: "{{ vm_name }}"
+    state: absent
+  when:
+    - vnet_autocreated
+    - azure_virtual_machine_with_public_ip_remove_on_absent in ['all', 'all_autocreated']
+
 - name: Delete Resource group if requested
   ansible.builtin.include_role:
     name: cloud.azure_ops.azure_manage_resource_group

tests/integration/targets/test_azure_virtual_machine_with_public_ip/aliases

@@ -0,0 +1,3 @@
+cloud/azure
+role/azure_virtual_machine_with_public_ip
+time=10m

tests/integration/targets/test_azure_virtual_machine_with_public_ip/defaults/main.yml

@@ -0,0 +1,10 @@
+---
+azure_virtual_machine_with_public_ip_vm_name: "{{ resource_prefix }}-vm"
+azure_virtual_machine_with_public_ip_vm_image:
+  offer: RHEL
+  publisher: RedHat
+  sku: 8-LVM
+  version: latest
+azure_virtual_machine_with_public_ip_vm_username: 'azureuser'
+azure_virtual_machine_with_public_ip_vm_admin_password: 'Password123!'
+azure_virtual_machine_with_public_ip_vm_size: Standard_B1s

tests/integration/targets/test_azure_virtual_machine_with_public_ip/tasks/ensure_no_vm_found.yml

@@ -0,0 +1,18 @@
+---
+- name: Ensure VM doesn't exist
+  block:
+    - name: Get VM by name
+      azure.azcollection.azure_rm_virtualmachine_info:
+        resource_group: "{{ vm_resource_group }}"
+        name: "{{ vm_name }}"
+      register: no_vm_info
+  rescue:
+    - name: VM doesn't exist as expected
+      when: ansible_failed_task.name == 'Get VM by name'
+      ansible.builtin.debug:
+        msg: VM doesn't exist as expected
+
+    - name: Force failure if VM was found or unexpected failure occurred
+      ansible.builtin.fail:
+        msg: "'{{ vm_name }}' exists and/or collected info is '{{ no_vm_info }}'"
+      when:  no_vm_info.msg is not contains 'ResourceNotFound'

tests/integration/targets/test_azure_virtual_machine_with_public_ip/tasks/main.yml

@@ -0,0 +1,94 @@
+---
+- name: Test azure_virtual_machine_with_public_ip role with default create/delete options
+  block:
+    - name: Ensure VM doesn't exist
+      ansible.builtin.include_tasks: "ensure_no_vm_found.yml"
+      vars:
+        vm_resource_group: "{{ resource_group }}"
+        vm_name: "{{ azure_virtual_machine_with_public_ip_vm_name }}"
+
+    - name: Set vars for test
+      ansible.builtin.set_fact:
+        azure_virtual_machine_with_public_ip_resource_group: "{{ resource_group }}"
+        azure_virtual_machine_with_public_ip_vm:
+          name: "{{ azure_virtual_machine_with_public_ip_vm_name }}"
+          admin_username: "{{ azure_virtual_machine_with_public_ip_vm_username }}"
+          admin_password: "{{ azure_virtual_machine_with_public_ip_vm_admin_password }}"
+          image: "{{ azure_virtual_machine_with_public_ip_vm_image }}"
+          size: "{{ azure_virtual_machine_with_public_ip_vm_size }}"
+
+    # Test: Create Virtual machine with default options
+    - name: Create Virtual machine with with a default network interface
+      ansible.builtin.include_role:
+        name: cloud.azure_ops.azure_virtual_machine_with_public_ip
+      vars:
+        azure_virtual_machine_with_public_ip_operation: create
+
+    # Verify VM has been created
+    - name: Ensure VM has been created
+      azure.azcollection.azure_rm_virtualmachine_info:
+        resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+        name: "{{ azure_virtual_machine_with_public_ip_vm.name }}"
+      register: vm_info
+
+    - name: Verify VM parameters
+      ansible.builtin.assert:
+        that:
+          - vm_info.vms[0].name == azure_virtual_machine_with_public_ip_vm.name
+          - vm_info.vms[0].network_interface_names[0] == azure_virtual_machine_with_public_ip_vm.name
+          - vm_info.vms[0].vm_size == azure_virtual_machine_with_public_ip_vm.size
+          - vm_info.vms[0].image.offer == azure_virtual_machine_with_public_ip_vm.image.offer
+          - vm_info.vms[0].power_state == "running"
+          - vm_info.vms[0].provisioning_state == "Succeeded"
+
+    # Test: Delete Virtual machine with default options
+    - name: Delete Virtual machine and all autocreated resources
+      ansible.builtin.include_role:
+        name: cloud.azure_ops.azure_virtual_machine_with_public_ip
+      vars:
+        azure_virtual_machine_with_public_ip_operation: delete
+
+    - name: Ensure VM doesn't exist
+      ansible.builtin.include_tasks: "ensure_no_vm_found.yml"
+      vars:
+        vm_resource_group: "{{ resource_group }}"
+        vm_name: "{{ azure_virtual_machine_with_public_ip_vm.name }}"
+
+    # Ensure all aurocreted resources have been deleted
+    - name: Get auto created NIC
+      azure_rm_networkinterface_info:
+        resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+        name: "{{ azure_virtual_machine_with_public_ip_vm.name }}"
+      register: nic_info
+
+    - name: Get auto created public IP
+      azure_rm_publicipaddress_info:
+        resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+        name: "{{ azure_virtual_machine_with_public_ip_vm.name }}"
+      register: pip_info
+
+    - name: Get auto created Virtual network
+      azure.azcollection.azure_rm_virtualnetwork_info:
+        resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
+        name: "{{ azure_virtual_machine_with_public_ip_vm.name }}"
+      register: vnet_info
+
+    - name: Assert that autocreated resources were deleted
+      ansible.builtin.assert:
+        that:
+          - nic_info.networkinterfaces | length == 0
+          - pip_info.publicipaddresses | length == 0
+          - vnet_info.virtualnetworks | length == 0
+
+  always:
+    - name: Delete Virtual Machine and specified associated resources
+      azure.azcollection.azure_rm_virtualmachine:
+        resource_group: "{{ resource_group }}"
+        name: "{{ azure_virtual_machine_with_public_ip_vm_name }}"
+        state: absent
+
+    - name: Delete autocreted virtual network
+      azure.azcollection.azure_rm_virtualnetwork:
+        state: absent
+        resource_group: "{{ resource_group }}"
+        name: "{{ azure_virtual_machine_with_public_ip_vm_name }}"