From 9ea85de89ea9c0f07eefe3c0fa53493dd2685350 Mon Sep 17 00:00:00 2001 From: hyaish Date: Sun, 21 Jul 2024 12:17:02 +0300 Subject: [PATCH] ACA-1602: Removing SKU tier, capacity and size parameters from role and test Signed-off-by: hyaish --- changelogs/fragments/20240721-azure_manage_postgresql.yml | 2 ++ roles/azure_manage_postgresql/README.md | 4 ---- .../targets/test_azure_manage_postgresql/defaults/main.yml | 1 - .../tasks/create_and_delete_postgresql.yml | 1 - 4 files changed, 2 insertions(+), 6 deletions(-) create mode 100644 changelogs/fragments/20240721-azure_manage_postgresql.yml diff --git a/changelogs/fragments/20240721-azure_manage_postgresql.yml b/changelogs/fragments/20240721-azure_manage_postgresql.yml new file mode 100644 index 0000000..3dc8f78 --- /dev/null +++ b/changelogs/fragments/20240721-azure_manage_postgresql.yml @@ -0,0 +1,2 @@ +bugfixes: + - Removing tier, capacity, and size from SKU parameters from README file, both from Role Variables and Example Playbook \ No newline at end of file diff --git a/roles/azure_manage_postgresql/README.md b/roles/azure_manage_postgresql/README.md index 7e890c1..313623f 100644 --- a/roles/azure_manage_postgresql/README.md +++ b/roles/azure_manage_postgresql/README.md @@ -19,9 +19,6 @@ Role Variables * **azure_manage_postgresql_postgresql_name**: The name of the Server. * **azure_manage_postgresql_postgresql_sku**: The SKU (pricing tier) of the server. - **name**: The name of the SKU, typically, tier + family + cores, for example **B_Gen4_1**, **GP_Gen5_8**. - - **tier**: The tier of the particular SKU. Valid values are **Basic**, **Standard**. - - **capacity**: The scale up/out capacity, representing the server's compute units. - - **size**: The size code, to be interpreted by resource as appropriate. * **azure_manage_postgresql_postgresql_storage_mb**: The maximum storage allowed for a server. * **azure_manage_postgresql_postgresql_geo_redundant_backup**: Choose between locally redundant(default) or geo-redundant backup. This cannot be updated after first deployment. Default: **False** * **azure_manage_postgresql_postgresql_backup_retention_days**: Backup retention period between 7 and 35 days. 7 days by default if not set @@ -78,7 +75,6 @@ Example Playbook azure_manage_postgresql_postgresql_storage_mb: 5120 azure_manage_postgresql_postgresql_sku: name: B_Gen5_1 - tier: Basic azure_manage_postgresql_resource_group_tags: tag0: "tag0" tag1: "tag1" diff --git a/tests/integration/targets/test_azure_manage_postgresql/defaults/main.yml b/tests/integration/targets/test_azure_manage_postgresql/defaults/main.yml index fa206f9..68d4526 100644 --- a/tests/integration/targets/test_azure_manage_postgresql/defaults/main.yml +++ b/tests/integration/targets/test_azure_manage_postgresql/defaults/main.yml @@ -3,6 +3,5 @@ azure_manage_postgresql_postgresql_name: "{{ resource_prefix }}-postgresql-serve azure_manage_postgresql_postgresql_admin_username: "ansible" azure_manage_postgresql_postgresql_sku: name: "B_Gen5_1" - tier: "Basic" azure_manage_postgresql_postgresql_storage_mb: 5120 azure_manage_postgresql_postgresql_backup_retention_days: 10 diff --git a/tests/integration/targets/test_azure_manage_postgresql/tasks/create_and_delete_postgresql.yml b/tests/integration/targets/test_azure_manage_postgresql/tasks/create_and_delete_postgresql.yml index 4b62379..b22ee62 100644 --- a/tests/integration/targets/test_azure_manage_postgresql/tasks/create_and_delete_postgresql.yml +++ b/tests/integration/targets/test_azure_manage_postgresql/tasks/create_and_delete_postgresql.yml @@ -37,7 +37,6 @@ - _postgresql.servers[0].name == azure_manage_postgresql_postgresql_name - _postgresql.servers[0].location == azure_manage_postgresql_region - _postgresql.servers[0].sku.name == azure_manage_postgresql_postgresql_sku.name - - _postgresql.servers[0].sku.tier == azure_manage_postgresql_postgresql_sku.tier - _postgresql.servers[0].storage_mb == azure_manage_postgresql_postgresql_storage_mb - _postgresql.servers[0].admin_username == azure_manage_postgresql_postgresql_admin_username - _postgresql.servers[0].version == azure_manage_postgresql_postgresql_version