Add support for credential type disambiguation in dispatch when multiple credentials share the same name

[daleroux]

Is your feature request related to a problem? Please describe.
Issue when using the infra.aap_configuration.dispatch role. The problem arises during Job Template creation: the role fails because there are two credentials with the same name in the AAP controller—one of type machine, the other of another type. Ansible expects a unique match by name, and since it finds two, it fails to resolve which credential to use.

Describe the solution you'd like
Modify filetree_create as well as dispatch (and controller_job_template) and add the credential type, allowing dispatch to zeron in on a unique credential.

Describe alternatives you've considered
Ensuring the name of credentials are unique in AAP is an alternative, but it may require a lot of manual work in environments where many credentials with the same name are present.

Additional context
This is currently impacting a customer migrating from 2.4 to 2.5 with CasC.

[djdanielsson]

well for the dispatch side try something like:

    credentials:
      - name: Demo Credential
        type: credential
        credential_type:
          name: Machine
          type: credential_type

[djdanielsson]

this repo does not have anything to do with filetree so if you are looking for changes made there you need to go to https://github.com/redhat-cop/aap_configuration_extended and put in that request

[djdanielsson]

what might be an easier example is here would be what the demo template looks like:

controller_templates:
  - name: Demo Job Template
    playbook: hello_world.yml
    inventory:
      name: Demo Inventory
      type: inventory
      organization:
        name: Default
        type: organization
    project:
      name: Demo Project
      type: project
      organization:
        name: Default
        type: organization
    credentials:
      - name: Demo Credential
        type: credential
        credential_type:
          name: Machine
          type: credential_type

[daleroux]

Hi David, I gave the above a try but it was unsuccessful. Access to a lab/reproducer is detailed in case 04205958 comment #2. Please let me know if you need anything. Thank you

[djdanielsson]

this does appear not to work currently, I have not had the time to look more into it. I changed it back to bug and we will see if we can come up with a different solution or make what i provided work. that will likely not happen in the near future and the current work around would be to not have any object have the same name.