test(e2e): add Github actions plugin tests #2838

prabinovRedhat · 2025-05-05T10:11:34Z

Description

Add Github actions plugin tests
Plugin reference https://www.npmjs.com/package/@backstage-community/plugin-github-actions

Which issue(s) does this PR fix

Fixes RHIDP-6710

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

openshift-ci · 2025-05-05T10:11:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign subhashkhileri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

e2e-tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-05-05T10:11:46Z

Hi @prabinovRedhat. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

prabinovRedhat · 2025-05-05T10:12:07Z

/cc @subhashkhileri @gustavolira

github-actions · 2025-05-05T11:36:34Z

The image is available at:

subhashkhileri · 2025-05-09T12:35:15Z

/ok-to-test

gustavolira · 2025-05-09T12:35:59Z

/ok-to-test

gustavolira · 2025-05-09T12:44:07Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+    await page.waitForSelector('table, div[role="grid"], [data-testid="plugins-table"]', { timeout: 30000 });
+    await page.waitForTimeout(3000); // Add a delay to ensure the table is fully rendered


Using page.waitForLoadState('networkidle') and page.waitForLoadState('domcontentloaded') is not recommended for modern web applications. These methods rely on global states that can be unreliable in dynamic applications with ongoing network requests (e.g., WebSockets or API polling). Instead, it’s better to wait for specific elements or components that indicate the page is fully loaded and interactive. For example, use
page.waitForSelector('[data-testid="plugins-table"]') to ensure tests are more reliable and maintainable.

gustavolira · 2025-05-09T12:45:46Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+    console.log(`Searching for plugin with term: ${searchTerm}`);
+
+    // Wait for search results
+    await page.waitForTimeout(2000);


Using await page.waitForTimeout(2000); is generally not a best practice as it introduces arbitrary delays that can make tests slower and less reliable. Instead, it’s better to wait for specific elements or conditions that indicate the page or component is ready. For example:
await page.waitForSelector('[data-testid="expected-element"]', { timeout: 10000 });

gustavolira · 2025-05-09T12:46:13Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+    await page.waitForLoadState('domcontentloaded', { timeout: 60000 });
+    await page.waitForLoadState('networkidle', { timeout: 60000 });


prabinovRedhat · 2025-05-11T09:41:18Z

@gustavolira Please take a look again, after my fixes

github-actions · 2025-05-11T10:20:27Z

The image is available at:

gustavolira · 2025-05-12T13:01:06Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+
+  test("Verify backstage-community-plugin-github-actions in Extensions page", async ({ page }) => {
+    // Navigate to Extensions page through Administration
+    await uiHelper.openSidebarButton("Administration");


Hi @prabinovRedhat can you please take this change in consideration
https://redhat-internal.slack.com/archives/C08JCP2F59B/p1746796660780629

Sure, when Shelly's or Nati's PR will be merged I'll use their function, is it ok?
@gustavolira

Except of this comment, I fixed all the rest

Let me know if it looks ok for you?

gustavolira · 2025-05-12T18:51:55Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+
+  test.beforeEach(async ({ page }) => {
+    // Increase default timeout to account for slower responses
+    test.setTimeout(180000); // 3 minutes


I think you can remove this timeout

gustavolira · 2025-05-12T18:53:48Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+    await expect(nameCell).toContainText("github-actions");
+
+    // Verify plugin status (Enabled and Preinstalled should both be "Yes")
+    const enabledCell = pluginRow.locator('td').nth(2);


Can you please check UiHelper.ts? I think there's some methods which you can reuse for it, for example verifyPluginRow

gustavolira · 2025-05-12T18:54:30Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+    await uiHelper.openSidebar("Catalog");
+    await uiHelper.selectMuiBox("Kind", "Component");
+    await uiHelper.clickByDataTestId("user-picker-all");


You can use UiHelper.openCatalogSidebar function

github-actions · 2025-05-13T11:49:18Z

The image is available at:

kadel · 2025-05-14T13:02:12Z

/test e2e-tests

kadel · 2025-05-14T13:03:55Z

e2e-tests/playwright/e2e/plugins/github-actions/github-actions.spec.ts

+    await uiHelper.searchInputPlaceholder(searchTerm);
+    console.log(`Searching for plugin with term: ${searchTerm}`);
+
+    // Use UIHelper to verify the plugin row instead of manual cell checking


Does it make sense to keep comments that were used as instruction for AI in the code?

you're right! I missed this one, I'll fix

fixed all comments

github-actions · 2025-05-14T13:39:33Z

The image is available at:

Assisted-by: Cursor

openshift-ci · 2025-05-21T10:15:42Z

@prabinovRedhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	`8353660`	link	true	`/test e2e-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

github-actions · 2025-05-21T10:33:41Z

The image is available at:

github-actions · 2025-05-29T02:11:28Z

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

prabinovRedhat · 2025-06-19T07:06:33Z

My PR was closed, I didn't succeed to re-open it, so I opened a new one - #3012

openshift-ci bot requested review from psrna and zdrapela May 5, 2025 10:11

openshift-ci bot added the needs-ok-to-test label May 5, 2025

openshift-ci bot requested review from gustavolira and subhashkhileri May 5, 2025 10:12

prabinovRedhat force-pushed the rhdh-github-actions branch 3 times, most recently from 6a6c876 to a113db5 Compare May 5, 2025 10:56

openshift-ci bot added ok-to-test and removed needs-ok-to-test labels May 9, 2025

gustavolira requested changes May 9, 2025

View reviewed changes

prabinovRedhat force-pushed the rhdh-github-actions branch 2 times, most recently from b2e4e67 to 4c5d838 Compare May 11, 2025 09:40

gustavolira requested changes May 12, 2025

View reviewed changes

prabinovRedhat force-pushed the rhdh-github-actions branch 2 times, most recently from 8044de6 to 056d7cc Compare May 13, 2025 11:49

kadel reviewed May 14, 2025

View reviewed changes

prabinovRedhat force-pushed the rhdh-github-actions branch from 056d7cc to c6b234e Compare May 14, 2025 13:39

prabinovRedhat force-pushed the rhdh-github-actions branch from c6b234e to b586d39 Compare May 21, 2025 09:46

prabinovRedhat force-pushed the rhdh-github-actions branch from b586d39 to a77792d Compare May 21, 2025 09:48

test(e2e): Add Github action plugin tests

8353660

Assisted-by: Cursor

prabinovRedhat force-pushed the rhdh-github-actions branch from a77792d to 8353660 Compare May 21, 2025 09:57

github-actions bot added the Stale label May 29, 2025

github-actions bot closed this Jun 19, 2025

prabinovRedhat changed the title ~~test(e2e): add Github actions plugin tests~~ test(e2e): add Github actions plugin test Jun 19, 2025

prabinovRedhat changed the title ~~test(e2e): add Github actions plugin test~~ test(e2e): add Github actions plugin tests Jun 19, 2025

		await page.waitForSelector('table, div[role="grid"], [data-testid="plugins-table"]', { timeout: 30000 });
		await page.waitForTimeout(3000); // Add a delay to ensure the table is fully rendered

		await page.waitForLoadState('domcontentloaded', { timeout: 60000 });
		await page.waitForLoadState('networkidle', { timeout: 60000 });

test(e2e): add Github actions plugin tests #2838

test(e2e): add Github actions plugin tests #2838

Uh oh!

Conversation

prabinovRedhat commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

Uh oh!

openshift-ci bot commented May 5, 2025

Uh oh!

openshift-ci bot commented May 5, 2025

Uh oh!

prabinovRedhat commented May 5, 2025

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

subhashkhileri commented May 9, 2025

Uh oh!

gustavolira commented May 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prabinovRedhat commented May 11, 2025

Uh oh!

github-actions bot commented May 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

kadel commented May 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

openshift-ci bot commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

prabinovRedhat commented Jun 19, 2025

Uh oh!

Uh oh!

prabinovRedhat commented May 5, 2025 •

edited

Loading