test(e2e): add github issues plugin test #3013
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @shellymiron. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gustavolira Hey! the previous PR got closed automatically, can you review again? |
|
The image is available at: |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
| async navigateToExtensions() { | ||
| await this.openSidebarButton("Administration"); | ||
| await this.clickLink("Extensions"); | ||
| await this.clickTab("Installed"); |
There was a problem hiding this comment.
@shellymiron This method is doing more than just navigation. would it make sense to move other clicks in test itself so in future someone want to use this method other than installed Tab they can use it.
| * @param componentName - The name of the component to navigate to | ||
| * @param tabName - The name of the tab to click, defaults to "Issues" | ||
| */ | ||
| async navigateToComponentIssues( |
There was a problem hiding this comment.
@shellymiron this method is doing assertions that are page specific and should not be in ui-helper as its designed only for generic methods. can we move this to respective page object/class?
|
/ok-to-test |
shellymiron
force-pushed
the
install-rhdh-locally
branch
from
d0a8fd8 to
89fed11
Compare
|
The image is available at: |
shellymiron
force-pushed
the
install-rhdh-locally
branch
from
89fed11 to
f3d3c2b
Compare
|
/test e2e-tests |
shellymiron
force-pushed
the
install-rhdh-locally
branch
from
f3d3c2b to
cee0378
Compare
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
just comment to remove stale label |
shellymiron
force-pushed
the
install-rhdh-locally
branch
from
cee0378 to
81f8e00
Compare
|
The image is available at: |
|
@shellymiron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
Description
Add Github Issues plugin tests
https://www.npmjs.com/package/@backstage-community/plugin-github-issues
Which issue(s) does this PR fix
Fixes https://issues.redhat.com/browse/RHIDP-6711
PR acceptance criteria
Please make sure that the following steps are complete: