-
Notifications
You must be signed in to change notification settings - Fork 197
feat(app-next): app-next initial spike #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-next): app-next initial spike #3046
Conversation
9b7ee5f
to
7d6ea7b
Compare
The image is available at: |
81dbf22
to
892e7da
Compare
The image is available at: |
The image is available at: |
/retest |
1 similar comment
/retest |
The image is available at: |
/retest |
1 similar comment
/retest |
67da63a
to
89da9bd
Compare
The image is available at: |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
The image is available at: |
8766a60
to
03cfd0c
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
The image is available at: |
This change introduces the new frontend system by adding a new app-next package. This new frontend can co-exist alongside the previous frontend system and is enabled by setting the following environment variable: ```bash export APP_CONFIG_app_packageName=app-next ``` before starting the RHDH backend. An additional start:next script has been added to the backend package, and it is also possible to use this environment variable to select the new frontend when using the RHDH container. Signed-off-by: Stan Lewis <[email protected]> Assisted-by: Cursor Desktop
The image is available at: |
/cherry-pick release-1.7 |
/lgtm |
@gashcrumb: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel, schultzp2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gashcrumb: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
449bac5
into
redhat-developer:main
@gashcrumb: new pull request created: #3132 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change introduces the new frontend system by adding a new app-next package. This new frontend can co-exist alongside the previous frontend system and is enabled by setting the following environment variable:
export APP_CONFIG_app_packageName=app-next
before starting the RHDH backend. An additional start:next script has been added to the backend package, and it is also possible to use this environment variable to select the new frontend when using the RHDH container.
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer