Skip to content

feat: add apic-backstage to rhdh marketplace #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

johns-thomas
Copy link

@johns-thomas johns-thomas commented Jul 8, 2025

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jul 8, 2025

Hi @johns-thomas. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@johns-thomas johns-thomas changed the title Add apic-backstage to rhdh marketplace feat: Add apic-backstage to rhdh marketplace Jul 8, 2025
@johns-thomas johns-thomas changed the title feat: Add apic-backstage to rhdh marketplace feat: add apic-backstage to rhdh marketplace Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

@johns-thomas
Copy link
Author

Hi @dzemanov & @its-mitesh-kumar could you please review my PR?

@christoph-jerolimov christoph-jerolimov self-assigned this Jul 16, 2025
@christoph-jerolimov
Copy link
Member

Hi @johns-thomas , sorry for the delay. I will take a look today.

Copy link
Member

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon for such a long wait.

I have tested how this looks:

Screenshot 2025-07-16 at 10 46 31 Screenshot 2025-07-16 at 10 46 43 Screenshot 2025-07-16 at 10 47 12

@johns-thomas johns-thomas requested a review from dzemanov July 16, 2025 20:16
@johns-thomas
Copy link
Author

Hi @christoph-jerolimov & @dzemanov, Thanks for reviewing PR. I have updated PR as per your comments. Could you please take a look? Also let me know if it is required to raise PR to any release branches. Thanks

Copy link
Contributor

Copy link
Contributor

@johns-thomas johns-thomas requested a review from dzemanov July 17, 2025 09:03
@dzemanov
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot removed the lgtm label Jul 18, 2025
@dzemanov
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 18, 2025
Copy link

openshift-ci bot commented Jul 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dzemanov
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@johns-thomas
Copy link
Author

/test e2e-tests

Copy link

openshift-ci bot commented Jul 18, 2025

@johns-thomas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dzemanov
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants