-
Notifications
You must be signed in to change notification settings - Fork 197
feat: add apic-backstage to rhdh marketplace #3088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @johns-thomas. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The image is available at: |
Hi @dzemanov & @its-mitesh-kumar could you please review my PR? |
Hi @johns-thomas , sorry for the delay. I will take a look today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catalog-entities/marketplace/plugins/ibm-apiconnect-backstage.yaml
Outdated
Show resolved
Hide resolved
catalog-entities/marketplace/plugins/ibm-apiconnect-backstage.yaml
Outdated
Show resolved
Hide resolved
catalog-entities/marketplace/packages/apic-backstage-plugin.yaml
Outdated
Show resolved
Hide resolved
catalog-entities/marketplace/packages/apic-backstage-plugin.yaml
Outdated
Show resolved
Hide resolved
catalog-entities/marketplace/plugins/ibm-apiconnect-backstage.yaml
Outdated
Show resolved
Hide resolved
Hi @christoph-jerolimov & @dzemanov, Thanks for reviewing PR. I have updated PR as per your comments. Could you please take a look? Also let me know if it is required to raise PR to any release branches. Thanks |
The image is available at: |
catalog-entities/marketplace/packages/apic-backstage-plugin.yaml
Outdated
Show resolved
Hide resolved
The image is available at: |
/lgtm |
catalog-entities/marketplace/packages/apic-backstage-plugin.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominika Zemanovicova <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dzemanov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
/test e2e-tests |
@johns-thomas: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer