Skip to content

chore: add workflow deployments for orchestrator testing #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

y-first
Copy link
Contributor

@y-first y-first commented Jul 8, 2025

Description

Adds some workflows for orchestrator plugin testing. Part of FLPATH-2318.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from albarbaro and psrna July 8, 2025 11:48
Copy link

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign albarbaro for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 8, 2025

Hi @y-first. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@y-first y-first force-pushed the add-workflow-deployment-for-orchestrator-testing branch from 846b224 to 220cfa0 Compare July 8, 2025 11:50
Copy link
Contributor

github-actions bot commented Jul 8, 2025

@subhashkhileri
Copy link
Member

/ok-to-test

Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Jul 16, 2025
@y-first y-first force-pushed the add-workflow-deployment-for-orchestrator-testing branch 2 times, most recently from d774792 to 559802c Compare July 17, 2025 09:26
Copy link
Contributor

@y-first y-first force-pushed the add-workflow-deployment-for-orchestrator-testing branch from 559802c to 1b821db Compare July 17, 2025 13:12
@y-first y-first force-pushed the add-workflow-deployment-for-orchestrator-testing branch 3 times, most recently from 7f503ea to 99050ca Compare July 17, 2025 19:01
Copy link
Contributor

@y-first y-first force-pushed the add-workflow-deployment-for-orchestrator-testing branch from 99050ca to 64093ec Compare July 17, 2025 20:11
@github-actions github-actions bot removed the Stale label Jul 18, 2025
@y-first y-first force-pushed the add-workflow-deployment-for-orchestrator-testing branch from 64093ec to ac2de88 Compare July 18, 2025 05:34
@@ -893,6 +893,8 @@ base_deployment() {
apply_yaml_files "${DIR}" "${NAME_SPACE}" "${rhdh_base_url}"
echo "Deploying image from repository: ${QUAY_REPO}, TAG_NAME: ${TAG_NAME}, in NAME_SPACE: ${NAME_SPACE}"
perform_helm_install "${RELEASE_NAME}" "${NAME_SPACE}" "${HELM_CHART_VALUE_FILE_NAME}"

deploy_orchestrator_workflows "${NAME_SPACE}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y-first Wouldn't a single deployment be sufficient for orchestrator testing? In this PR, I see it being deployed to both showcase and showcase-rbac.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants