-
Notifications
You must be signed in to change notification settings - Fork 197
chore(init): skip including dynamic packages if file not exists #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(init): skip including dynamic packages if file not exists #3120
Conversation
Signed-off-by: Dominika Zemanovicova <[email protected]>
Skipping CI for Draft Pull Request. |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When someone makes a typo in a filename, it is easy to miss that message. I would prefix it with WARNING
to make it more visible.
otherwise LGTM
Co-authored-by: Tomas Kral <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrienkoAleksandr, kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
0c10092
into
redhat-developer:main
/cherry-pick release-1.7 |
@dzemanov: new pull request created: #3145 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Skip including dynamic packages if file does not exist, as it will be created the first time by extensions with this config:
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer