Skip to content

chore(init): skip including dynamic packages if file not exists #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dzemanov
Copy link
Member

Description

Skip including dynamic packages if file does not exist, as it will be created the first time by extensions with this config:

plugins: []

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jul 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dzemanov dzemanov changed the title feat(extensions): Skip including dynamic packages if file not exists chore(init): Skip including dynamic packages if file not exists Jul 14, 2025
@dzemanov dzemanov changed the title chore(init): Skip including dynamic packages if file not exists chore(init): skip including dynamic packages if file not exists Jul 14, 2025
Copy link
Contributor

@dzemanov dzemanov marked this pull request as ready for review July 14, 2025 13:45
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When someone makes a typo in a filename, it is easy to miss that message. I would prefix it with WARNING to make it more visible.

otherwise LGTM

@kadel
Copy link
Member

kadel commented Jul 14, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrienkoAleksandr, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@openshift-merge-bot openshift-merge-bot bot merged commit 0c10092 into redhat-developer:main Jul 14, 2025
13 checks passed
@dzemanov
Copy link
Member Author

/cherry-pick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

@dzemanov: new pull request created: #3145

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants