Skip to content

Adopt the Lombok 1.18.33 edge release. #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

marco-belonio
Copy link
Contributor

@marco-belonio marco-belonio commented Jun 11, 2024

@blizzy78
Copy link

But edge != latest version?

@sleberknight
Copy link

From the Downloads page, it looks like you can use the generic link:

https://projectlombok.org/downloads/lombok.jar

I am assuming (but don't know for sure) that this link will always get the latest stable version. As of right now, that is 1.18.32 - the link text is Download 1.18.32

So maybe just need to use this link and then will always get the most recent stable version?

@rgrunber
Copy link
Member

Thanks for getting this started. I remember when the original issue was filed but didn't see any progress for a long while.

Could you make the change look like the gulpfile at b59c43a#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7 ? This won't require changing any runtime code. Instead of 1.18.31 (the unreleased version that "edge" was targetting then), call it 1.18.33.

If the edge release contains a fix, we can definitely adopt.

@marco-belonio
Copy link
Contributor Author

@sleberknight The problem is, that the 1.18.32 does not work to resolve the problem :S

@sleberknight
Copy link

@sleberknight The problem is, that the 1.18.32 does not work to resolve the problem :S

Oops. Sorry! Clearly I missed that important part.

@rgrunber rgrunber self-requested a review June 12, 2024 14:15
Co-authored-by: Marco Klein <[email protected]>
Co-authored-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber changed the title fix: 🐛 Always download the latest lombok version Adopt the Lombok 1.18.33 edge release. Jun 13, 2024
@rgrunber rgrunber merged commit 70ebc3e into redhat-developer:master Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants