Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add languages yaml-textmate & yaml-tmlanguage #1093

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add languages yaml-textmate & yaml-tmlanguage #1093

wants to merge 2 commits into from

Conversation

RedCMD
Copy link

@RedCMD RedCMD commented Feb 9, 2025

Fixes #1092

I could add them to "activationEvents" as well
but the 3rd party extensions can activate this one instead via "extensionDependencies"

vscode-yaml/package.json

Lines 41 to 44 in e696d9b

"activationEvents": [
"onLanguage:yaml",
"onLanguage:dockercompose"
],

also I think *.y(a)ml is a invalid glob pattern

vscode-yaml/src/extension.ts

Line 119 in e696d9b

documentSelector: [{ language: 'yaml' }, { language: 'dockercompose' }, { pattern: '*.y(a)ml' }],

@RedCMD RedCMD mentioned this pull request Feb 9, 2025
Open
@albertocavalcante albertocavalcante mentioned this pull request Mar 7, 2025
Merged
msivasubramaniaan
msivasubramaniaan requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update it on

vscode-yaml/package.json

Lines 41 to 44 in e696d9b

"activationEvents": [
"onLanguage:yaml",
"onLanguage:dockercompose"
],
as well

@RedCMD
Copy link
Author

RedCMD commented Mar 11, 2025

@msivasubramaniaan done thanks

@msivasubramaniaan
Copy link
Contributor

@RedCMD Please resolve the conflicts. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msivasubramaniaan msivasubramaniaan msivasubramaniaan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support YAML TextMate files
2 participants
@RedCMD @msivasubramaniaan