add tests

Author: q-rault

src/languageservice/services/yamlHover.ts

@@ -6,7 +6,7 @@
 
 import { Hover, MarkupContent, MarkupKind, Position, Range } from 'vscode-languageserver-types';
 import { matchOffsetToDocument } from '../utils/arrUtils';
-import { LanguageSettings } from '../yamlLanguageService';
+import { LanguageSettings, HoverSettings } from '../yamlLanguageService';
 import { YAMLSchemaService } from './yamlSchemaService';
 import { setKubernetesParserOption } from '../parser/isKubernetes';
 import { TextDocument } from 'vscode-languageserver-textdocument';
@@ -24,7 +24,7 @@ import { stringify as stringifyYAML } from 'yaml';
 export class YAMLHover {
   private shouldHover: boolean;
   private indentation: string;
-  private hoverSettings: LanguageSettings['hoverSettings'];
+  private hoverSettings: HoverSettings;
   private schemaService: YAMLSchemaService;
 
   constructor(schemaService: YAMLSchemaService, private readonly telemetry?: Telemetry) {
@@ -36,7 +36,7 @@ export class YAMLHover {
     if (languageSettings) {
       this.shouldHover = languageSettings.hover;
       this.indentation = languageSettings.indentation;
-      this.hoverSettings = languageSettings.hoverSettings;
+      this.hoverSettings = languageSettings.hoverSettings ?? {};
     }
   }
 
@@ -105,9 +105,8 @@ export class YAMLHover {
       return value.replace(/\|\|\s*$/, '');
     };
 
-    const hoverSettings = this.hoverSettings || {};
-    const showSource = !!hoverSettings?.showSource;
-    const showTitle = !!hoverSettings?.showTitle;
+    const showSource = this.hoverSettings?.showSource ?? true; // showSource enabled by default
+    const showTitle = this.hoverSettings?.showTitle ?? true; // showTitle enabled by default
 
     return this.schemaService.getSchemaForResource(document.uri, doc).then((schema) => {
       if (schema && node && !schema.errors.length) {

src/languageservice/yamlLanguageService.ts

@@ -71,10 +71,15 @@ export interface SchemasSettings {
   versions?: SchemaVersions;
 }
 
+export interface HoverSettings {
+  showSource?: boolean;
+  showTitle?: boolean;
+}
+
 export interface LanguageSettings {
   validate?: boolean; //Setting for whether we want to validate the schema
   hover?: boolean; //Setting for whether we want to have hover results
-  hoverSettings?: { showSource?: boolean; showTitle?: boolean }; // Settings for hover parts
+  hoverSettings?: HoverSettings; // Settings for hover parts
   completion?: boolean; //Setting for whether we want to have completion results
   format?: boolean; //Setting for whether we want to have the formatter or not
   isKubernetes?: boolean; //If true then its validating against kubernetes

test/utils/serviceSetup.ts

@@ -2,7 +2,7 @@
  *  Copyright (c) Red Hat. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-import { LanguageSettings, SchemasSettings } from '../../src/languageservice/yamlLanguageService';
+import { HoverSettings, LanguageSettings, SchemasSettings } from '../../src/languageservice/yamlLanguageService';
 
 export class ServiceSetup {
   /*
@@ -12,6 +12,7 @@ export class ServiceSetup {
   languageSettings: LanguageSettings = {
     validate: false,
     hover: false,
+    hoverSettings: {},
     completion: false,
     format: false,
     isKubernetes: false,
@@ -33,6 +34,11 @@ export class ServiceSetup {
     return this;
   }
 
+  withHoverSettings(hoverSettings: HoverSettings): ServiceSetup {
+    this.languageSettings.hoverSettings = hoverSettings;
+    return this;
+  }
+
   withCompletion(): ServiceSetup {
     this.languageSettings.completion = true;
     return this;