Merge pull request #80 from yfried-redhat/old_install

Revert Installer to old OSPD

Author: tkammer-zz

playbooks/install.yml

@@ -3,7 +3,7 @@
   hosts: openstack_nodes
   sudo: yes
   tasks:
-    - debug: "var={{ installer.selinux | default('enforcing') }}"
+    - selinux: policy=targeted state={{ installer.selinux|default('enforcing') }}
 
 - name: Ensure yum presence
   hosts: openstack_nodes

playbooks/installer/ospd/overcloud/pre.yml

@@ -11,8 +11,8 @@
             msg: "Stopping before building/importing the images per user request"
         when: break is defined and break == "before_images"
   roles:
-      - {role: ospd/overcloud/images/build, when: installer.overcloud.images is not defined installer.overcloud.images.server is not defined}
-      - {role: ospd/overcloud/images/import, when: installer.overcloud.images is defined and installer.overcloud.images.server is defined}
+      - {role: ospd/overcloud/images/build, when: installer.images.task == "build"}
+      - {role: ospd/overcloud/images/import, when: installer.images.task == "import"}
   tasks:
       - name: upload the overcloud images to glance
         shell: "source ~/stackrc; openstack overcloud image upload"

playbooks/installer/ospd/overcloud/run.yml

@@ -18,9 +18,9 @@
             dest: "~/overcloud_deploy.sh"
             mode: 0755
   roles:
-      - {role: "ospd/overcloud/storage/ceph/", when: provisioner.nodes.ceph is defined or installer.overcloud.storage.type == "external"}
+      - {role: "ospd/overcloud/storage/ceph/", when: provisioner.nodes.ceph is defined or installer.overcloud.storage.external == "yes"}
       - {role: "ospd/overcloud/network/isolation/{{ installer.overcloud.network.isolation.type }}/", when: installer.overcloud.network.isolation.enable == "yes"}
-      - {role: "ospd/overcloud/ssl/", when: installer.overcloud.network.ssl == "yes"}
+      - {role: "ospd/overcloud/ssl/", when: installer.overcloud.use_ssl == "yes"}
 
 - name: Install the overcloud
   hosts: undercloud

playbooks/installer/ospd/undercloud/pre.yml

@@ -16,25 +16,23 @@
       command: "rm -f /etc/yum.repos.d/*"
 
     - name: install the rhos-release RPM
-      shell: "yum localinstall -y {{ installer.product.rpm }}"
+      shell: "yum localinstall -y {{ product.rpm }}"
 
     - debug:
-          msg: "rhos-release {{ installer.product.version }}-director -p {{ installer.product.build }}"
+          msg: "rhos-release {{ installer.version.major }}-director -p {{ installer.build }}"
 
     - name: create necessary repos with for director using rhos-release
-      command: "rhos-release {{ installer.product.version }}-director -p {{ installer.product.build }}"
+      command: "rhos-release {{ installer.version.major }}-director -p {{ installer.build }}"
       register: command_result
       until: command_result.stderr.find('Connection reset by peer') == -1
       retries: 40
       delay: 5
 
     - debug:
-          msg: "rhos-release {{ installer.productcore.version }} -p {{ installer.product.core.build }}"
-      when: prodcut.core is defined
+          msg: "rhos-release {{ product.version.major }} -p {{ product.build }}"
 
     - name: create necessary repos for core using rhos-release
-      command: "rhos-release {{ installer.productcore.version }} -p {{ installer.product.core.build }}"
-      when: prodcut.core is defined
+      command: "rhos-release {{ product.version.major }} -p {{ product.build }}"
 
     - name: update system packages
       yum:
@@ -61,7 +59,7 @@
   tasks:
     - name: Install the oscplugin/tripleO client
       yum:
-          name: "{% if installer.product.version == '7' %}python-rdomanager-oscplugin{% else %}python-tripleoclient{% endif %}"
+          name: "{% if installer.version.major == 7 %}python-rdomanager-oscplugin{% else %}python-tripleoclient{% endif %}"
           state: present
 
     - name: create user

roles/ospd/overcloud/images/import/tasks/main.yml

@@ -2,9 +2,9 @@
 - name: download the pre-built overcloud images
   get_url:
       dest: "~/{{ item.value }}"
-      url: "{{ installer.overcloud.images.server }}/{{ item.value }}"
-  with_dict: "{{ installer.overcloud.images.files }}"
+      url: "{{ installer.images.base_url }}/{{ item.value }}"
+  with_dict: "{{ installer.images.overcloud.files }}"
 
 - name: untar the images
   shell: "tar -xvf ~/{{ item.value }}"
-  with_dict: "{{ installer.overcloud.images.files }}"
+  with_dict: "{{ installer.images.overcloud.files }}"

roles/ospd/overcloud/network/isolation/single-nic-vlans/tasks/main.yml

@@ -17,9 +17,9 @@
       line: '                       -e {{ installer.overcloud.template_base }}/{{ installer.overcloud.network.isolation.file }} \\'
 
 - name: add port to br-ctlplane for ipv6 over vlan support
-  shell: "sudo ovs-vsctl add-port br-ctlplane vlan{{ installer.overcloud.network.template.parameter_defaults.ExternalNetworkVlanID }} tag={{ installer.overcloud.network.template.parameter_defaults.ExternalNetworkVlanID }} -- set interface vlan{{ installer.overcloud.network.template.parameter_defaults.ExternalNetworkVlanID }} type=internal"
+  shell: "sudo ovs-vsctl add-port br-ctlplane vlan{{ installer.overcloud.network.template.content.parameter_defaults.ExternalNetworkVlanID }} tag={{ installer.overcloud.network.template.content.parameter_defaults.ExternalNetworkVlanID }} -- set interface vlan{{ installer.overcloud.network.template.content.parameter_defaults.ExternalNetworkVlanID }} type=internal"
   when: installer.overcloud.network.backend == 'vlan'
 
 - name: add the ipv6 address
-  shell: "sudo ip l set dev vlan{{ installer.overcloud.network.template.parameter_defaults.ExternalNetworkVlanID }} up; sudo ip addr add {{ installer.overcloud.network.template.parameter_defaults.ExternalInterfaceDefaultRoute }}/64 dev vlan{{ installer.overcloud.network.template.parameter_defaults.ExternalNetworkVlanID }}"
+  shell: "sudo ip l set dev vlan{{ installer.overcloud.network.template.content.parameter_defaults.ExternalNetworkVlanID }} up; sudo ip addr add {{ installer.overcloud.network.template.content.parameter_defaults.ExternalInterfaceDefaultRoute }}/64 dev vlan{{ installer.overcloud.network.template.content.parameter_defaults.ExternalNetworkVlanID }}"
   when: installer.overcloud.network.backend == 'vlan'

roles/ospd/overcloud/network/isolation/single-nic-vlans/templates/isolation.yml.j2

@@ -1 +1 @@
-{{ installer.overcloud.network.template | to_yaml }}
+{{ installer.overcloud.network.template.content | to_yaml }}

roles/ospd/overcloud/network/isolation/three-nics-vlans/templates/network-environment.yaml.j2

@@ -1 +1 @@
-{{ installer.overcloud.network.template | to_yaml }}
+{{ installer.overcloud.network.template.content | to_yaml }}

roles/ospd/overcloud/ssl/tasks/main.yml

@@ -2,7 +2,7 @@
   shell: "openssl genrsa -out {{ installer.overcloud.template_base }}/overcloud-privkey.pem 2048"
 
 - name: create the self signed CA certificate
-  shell: "openssl req -new -x509 -key {{ installer.overcloud.template_base }}/overcloud-privkey.pem -out {{ installer.overcloud.template_base }}/overcloud-cacert.pem -days 365 -subj '/C=US/ST=NC/L=Raleigh/O=Red HAt/OU=QE/CN={{ installer.overcloud.network.template.parameter_defaults.ExternalAllocationPools[0].start }}'"
+  shell: "openssl req -new -x509 -key {{ installer.overcloud.template_base }}/overcloud-privkey.pem -out {{ installer.overcloud.template_base }}/overcloud-cacert.pem -days 365 -subj '/C=US/ST=NC/L=Raleigh/O=Red HAt/OU=QE/CN={{ installer.overcloud.network.template.content.parameter_defaults.ExternalAllocationPools[0].start }}'"
 
 - name: update the tls template
   shell: "sed -i 's/CLOUDNAME/IP_ADDRESS/' {{ installer.overcloud.template_base }}/environments/enable-tls.yaml"

roles/ospd/overcloud/storage/ceph/tasks/main.yml

@@ -8,13 +8,13 @@
   lineinfile:
       dest: "~/overcloud_deploy.sh"
       line: '                       --ceph-storage-scale {{ groups["ceph"]| length }} \\'
-  when: installer.overcloud.storage.type == "internal"
+  when: installer.overcloud.storage.external == "no"
 
 - name: append the ceph storage template line to the base overcloud deploy script
   lineinfile:
       dest: "~/overcloud_deploy.sh"
       line: '{% for flavor in tagged_flavors %}{% if flavor.cmd is defined and "ceph" in flavor.cmd %}                       --ceph-storage-flavor {{ flavor.cmd.split() | last }} \\{% endif %}{% endfor %}'
-  when: installer.overcloud.storage.type == "internal"
+  when: installer.overcloud.storage.external == "no"
 
 - name: append the storage template line to the base overcloud deploy script
   lineinfile:
@@ -24,4 +24,4 @@
 - name: append the storage ceph custom template line to the base overcloud deploy script
   lineinfile:
       dest: "~/overcloud_deploy.sh"
-      line: '                       -e {{ installer.overcloud.template_base }}/custom-ceph.yaml \\'
+      line: '                       -e {{ installer.overcloud.template_base }}/custom-ceph.yaml \\'