Revalidate connection in RedisClient#connected?

Otherwise if it has pending reads it will be closed when used anyway.
redis-rb · Dec 7, 2023 · 2106ae2 · 2106ae2
1 parent 8a3dafd
commit 2106ae2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # Unreleased
 
+- Revalidate connection in `RedisClient#connected?`
 - Eagerly fail if `db:` isn't an Integer. #151.
 
 # 0.18.0

diff --git a/lib/redis_client.rb b/lib/redis_client.rb
@@ -222,17 +222,18 @@ def with(_options = nil)
 
   def timeout=(timeout)
     super
-    raw_connection.read_timeout = raw_connection.write_timeout = timeout if connected?
+    @raw_connection&.read_timeout = timeout
+    @raw_connection&.write_timeout = timeout
   end
 
   def read_timeout=(timeout)
     super
-    raw_connection.read_timeout = timeout if connected?
+    @raw_connection&.read_timeout = timeout
   end
 
   def write_timeout=(timeout)
     super
-    raw_connection.write_timeout = timeout if connected?
+    @raw_connection&.write_timeout = timeout
   end
 
   def pubsub
@@ -386,7 +387,7 @@ def zscan(key, *args, **kwargs, &block)
   end
 
   def connected?
-    @raw_connection&.connected?
+    @raw_connection&.revalidate
   end
 
   def close