Extracted out Beta API skipping to a separate component

Author: galovics

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/PathSkipper.java

@@ -0,0 +1,11 @@
+package io.redskap.swagger.brake.core.rule;
+
+import io.redskap.swagger.brake.core.model.Path;
+import org.springframework.stereotype.Component;
+
+@Component
+public class PathSkipper {
+    public boolean shouldSkip(Path path) {
+        return path.isBetaApi();
+    }
+}

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/path/PathDeletedRule.java

@@ -8,6 +8,7 @@
 import io.redskap.swagger.brake.core.model.Path;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
@@ -16,6 +17,7 @@
 @Slf4j
 @RequiredArgsConstructor
 public class PathDeletedRule implements BreakingChangeRule<PathDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
     private final CheckerOptionsProvider checkerOptionsProvider;
 
     @Override
@@ -24,7 +26,7 @@ public Collection<PathDeletedBreakingChange> checkRule(Specification oldApi, Spe
         CheckerOptions checkerOptions = checkerOptionsProvider.get();
         Collection<PathDeletedBreakingChange> breakingChanges = new ArrayList<>();
         for (Path p : oldApi.getPaths()) {
-            if (p.isBetaApi()) {
+            if (pathSkipper.shouldSkip(p)) {
                 log.debug("Skipping {} as it's marked as a beta API", p);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestMediaTypeDeletedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestMediaTypeDeletedRule implements BreakingChangeRule<RequestMediaTypeDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestMediaTypeDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestMediaTypeDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestParameterDeletedRule.java

@@ -9,16 +9,21 @@
 import io.redskap.swagger.brake.core.model.RequestParameter;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import org.apache.commons.collections4.CollectionUtils;
 import org.springframework.stereotype.Component;
 
 @Component
+@RequiredArgsConstructor
 public class RequestParameterDeletedRule implements BreakingChangeRule<RequestParameterDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestParameterDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestParameterDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 continue;
             }
             Optional<Path> newApiPath = newApi.getPath(path);

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestParameterEnumValueDeletedRule.java

@@ -10,18 +10,23 @@
 import io.redskap.swagger.brake.core.model.Schema;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.collections4.CollectionUtils;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestParameterEnumValueDeletedRule  implements BreakingChangeRule<RequestParameterEnumValueDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestParameterEnumValueDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestParameterEnumValueDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestParameterInTypeChangedRule.java

@@ -9,18 +9,23 @@
 import io.redskap.swagger.brake.core.model.RequestParameter;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.collections4.CollectionUtils;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestParameterInTypeChangedRule implements BreakingChangeRule<RequestParameterInTypeChangedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestParameterInTypeChangedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestParameterInTypeChangedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestParameterRequiredRule.java

@@ -9,18 +9,23 @@
 import io.redskap.swagger.brake.core.model.RequestParameter;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.collections4.CollectionUtils;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestParameterRequiredRule implements BreakingChangeRule<RequestParameterRequiredBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestParameterRequiredBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestParameterRequiredBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestParameterTypeChangedRule.java

@@ -7,18 +7,23 @@
 import io.redskap.swagger.brake.core.model.Schema;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.collections4.CollectionUtils;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestParameterTypeChangedRule implements BreakingChangeRule<RequestParameterTypeChangedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestParameterTypeChangedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestParameterTypeChangedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestTypeAttributeRemovedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestTypeAttributeRemovedRule implements BreakingChangeRule<RequestTypeAttributeRemovedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestTypeAttributeRemovedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestTypeAttributeRemovedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestTypeChangedRule.java

@@ -7,18 +7,23 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.collections4.CollectionUtils;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestTypeChangedRule implements BreakingChangeRule<RequestTypeChangedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestTypeChangedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestTypeChangedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/request/RequestTypeEnumValueDeletedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class RequestTypeEnumValueDeletedRule implements BreakingChangeRule<RequestTypeEnumValueDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<RequestTypeEnumValueDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<RequestTypeEnumValueDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/response/ResponseDeletedRule.java

@@ -9,17 +9,22 @@
 import io.redskap.swagger.brake.core.model.Response;
 import io.redskap.swagger.brake.core.model.Specification;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class ResponseDeletedRule implements BreakingChangeRule<ResponseDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<ResponseDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<ResponseDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/response/ResponseMediaTypeDeletedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class ResponseMediaTypeDeletedRule implements BreakingChangeRule<ResponseMediaTypeDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<ResponseMediaTypeDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<ResponseMediaTypeDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/response/ResponseTypeAttributeRemovedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class ResponseTypeAttributeRemovedRule implements BreakingChangeRule<ResponseTypeAttributeRemovedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<ResponseTypeAttributeRemovedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<ResponseTypeAttributeRemovedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/response/ResponseTypeChangedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class ResponseTypeChangedRule implements BreakingChangeRule<ResponseTypeChangedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<ResponseTypeChangedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<ResponseTypeChangedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }

swagger-brake/src/main/java/io/redskap/swagger/brake/core/rule/response/ResponseTypeEnumValueDeletedRule.java

@@ -4,17 +4,22 @@
 
 import io.redskap.swagger.brake.core.model.*;
 import io.redskap.swagger.brake.core.rule.BreakingChangeRule;
+import io.redskap.swagger.brake.core.rule.PathSkipper;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
+@RequiredArgsConstructor
 public class ResponseTypeEnumValueDeletedRule implements BreakingChangeRule<ResponseTypeEnumValueDeletedBreakingChange> {
+    private final PathSkipper pathSkipper;
+
     @Override
     public Collection<ResponseTypeEnumValueDeletedBreakingChange> checkRule(Specification oldApi, Specification newApi) {
         Set<ResponseTypeEnumValueDeletedBreakingChange> breakingChanges = new HashSet<>();
         for (Path path : oldApi.getPaths()) {
-            if (path.isBetaApi()) {
+            if (pathSkipper.shouldSkip(path)) {
                 log.debug("Skipping {} as it's marked as a beta API", path);
                 continue;
             }