-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve Supabase liveProvider filter handling #6573
base: next
Are you sure you want to change the base?
fix: improve Supabase liveProvider filter handling #6573
Conversation
…nd configurable meta.realtimeFilter
🦋 Changeset detectedLatest commit: 89e14aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @OmkarBansod02 thanks for the updates. Did you test this one locally? Would be nice to have a screen recording with devtools enabled to see if this works as expected.
Hey @BatuhanW , I have tested the changes from the PR locally, and it appears to be working fine. Below are the screen recordings demonstrating the behavior with both a single filter and multiple filters:
single.filter.mp4
multiple.Filters.mp4In the case of multiple filters, as expected, the system logs a warning and uses only the first filter. This matches the intended behavior outlined in the PR. However, I didn't observe the WebSocket error mentioned in the issue description it's possible I may have missed something. Please take a look and let me know if there are any other scenarios I should test. |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Supabase Realtime doesn't support multiple filters, causing errors in requests when more than one filter is used.
What is the new behavior?
Supabase Realtime handles one filter at a time, logs a warning for multiple filters, and allows overriding the filter with
meta.realtimeFilter
for more control.fixes #6360
Notes for reviewers
I’ve made the changes as discussed in the issue and added support for handling single filters in the Supabase liveProvider. Please take a look at the implementation and let me know if any further adjustments are needed.