Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react-router-upgrade): remove extra double quote and correct version #6602

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

phwt
Copy link
Contributor

@phwt phwt commented Dec 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Documentation Changes

  • Remove the extra trailing double quote (") after the refine-codemod command which causes the command to fail
  • Update the example @refinedev/react-router version changes to ^1.0.1, as the current version (as of 12/2024) is 1.0.1 this will help prevent confusion when verifying the upgrade

Copy link

changeset-bot bot commented Dec 22, 2024

⚠️ No Changeset found

Latest commit: 2b7375b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2b7375b
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/6767ddaef051c90008768f30
😎 Deploy Preview https://deploy-preview-6602--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phwt phwt marked this pull request as ready for review December 22, 2024 09:55
@phwt phwt requested a review from a team as a code owner December 22, 2024 09:55
@BatuhanW BatuhanW merged commit 1e263d9 into refinedev:main Dec 24, 2024
5 checks passed
@phwt phwt deleted the patch-1 branch December 24, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants