Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue #5954 #6633

Closed
wants to merge 2 commits into from
Closed

Fixing Issue #5954 #6633

wants to merge 2 commits into from

Conversation

Ananmayd
Copy link

@Ananmayd Ananmayd commented Jan 5, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

The form modal was showing the data for the previously opened modal for a short time on opening the new modal.

What is the new behavior?

The previously open data is not being shown now on opening the new modal.

fixes (issue)
The keepPreviousData option in the queryOptions of the useForm.ts file is set to false by default in the refine/package.antd package has been updated.

Notes for reviewers

@Ananmayd Ananmayd requested a review from a team as a code owner January 5, 2025 11:35
Copy link

changeset-bot bot commented Jan 5, 2025

🦋 Changeset detected

Latest commit: 142bd40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@refinedev/antd Major
@refinedev/inferencer Major
@refinedev/live-previews Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 142bd40
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/677a6e92c6bcd7000855adba
😎 Deploy Preview https://deploy-preview-6633--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alicanerdurmaz
Copy link
Member

Hello @Ananmayd,

This PR resolves the related issue indirectly rather than directly. It causes a breaking change and is not an ideal solution.

If you want keepPreviousData: false in your useForm instances, you can configure it from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants