Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve/decline snapshot #314

Open
IlyaPuchkaTW opened this issue Aug 21, 2020 · 4 comments
Open

Approve/decline snapshot #314

IlyaPuchkaTW opened this issue Aug 21, 2020 · 4 comments

Comments

@IlyaPuchkaTW
Copy link

Is your feature request related to a problem? Please describe.

Some similar tools like Chromatic, Percy or Happo support approving/declining particular snapshot changes and integrate with GitHub status checks.

Describe the solution you'd like

Generated report should have button to approve/decline all or some snapshots that should post GitHub status check update. This web hook url can be something that developer should pass to the tool manually as a parameter and these buttons could simply call these urls to publish update. When all snapshots are approved status is updated with success.
It would be nice also to be able to filter by approved/declined PRs but that would require some sort of persistence for the state of snapshot.

Describe alternatives you've considered

Right now users would have to request changes on PRs and give a feedback manually.

@IlyaPuchkaTW
Copy link
Author

IlyaPuchkaTW commented Sep 10, 2020

Thanks for the reference! I don't quite get how this part about "Approve Review Changes" is done and can't see it in any demos.

@Quramy
Copy link
Member

Quramy commented Sep 10, 2020

If reg-suit detects visual difference (i.e. snapshot changes), reg-suit sets corresponding PR's status to failure.

スクリーンショット 2020-09-10 22 50 05.

And this status can be succeeded if your reviewers approve the PR. reg-suit's GitHub integration uses webhook and subscribe PR status change event.

@IlyaPuchkaTW
Copy link
Author

I see now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants