Merge pull request #48 from rehanvdm/feature/vacuum-s3-cleanup

fix: vacuum process does not clean s3 files #47

Author: rehanvdm

src/backend.ts

@@ -282,12 +282,8 @@ export function backend(
       effect: Effect.ALLOW,
       actions: ['s3:DeleteObject'],
       resources: [
-        backendAnalyticsProps.analyticsBucket.arnForObjects(
-          'page_views/site=*/page_opened_at_date=*/' + backendAnalyticsProps.firehosePageViews.deliveryStreamName! + '*'
-        ),
-        backendAnalyticsProps.analyticsBucket.arnForObjects(
-          'page_views/site=*/page_opened_at_date=*/' + backendAnalyticsProps.firehoseEvents.deliveryStreamName! + '*'
-        ),
+        backendAnalyticsProps.analyticsBucket.arnForObjects('page_views/site=*/page_opened_at_date=*/*'),
+        backendAnalyticsProps.analyticsBucket.arnForObjects('page_views/site=*/page_opened_at_date=*/*'),
       ],
     })
   );

src/src/backend/lib/utils/s3_base.ts

@@ -42,7 +42,7 @@ export class S3Base {
     for (const key of keys) {
       promises.push(
         limit(() => {
-          this.s3Client.send(
+          return this.s3Client.send(
             new DeleteObjectCommand({
               Bucket: this.bucketName,
               Key: key,