Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a little bit about inaccurate variable types and names #971

Open
NoobWithCheats opened this issue Jun 30, 2024 · 0 comments
Open

a little bit about inaccurate variable types and names #971

NoobWithCheats opened this issue Jun 30, 2024 · 0 comments

Comments

@NoobWithCheats
Copy link

https://github.com/s1lentq/ReGameDLL_CS/blob/a94c7bd728a2b2b80b016ee86f3310459e872e0d/regamedll/dlls/weapons.h#L436
does it make sense to switch from BOOL to bool? and using bool m_bDirection; OR BOOL m_bDirection;?

https://github.com/s1lentq/ReGameDLL_CS/blob/a94c7bd728a2b2b80b016ee86f3310459e872e0d/regamedll/dlls/weapons.h#L421
It is only used to define true and false. Using bool m_bFireOnEmpty;

https://github.com/s1lentq/ReGameDLL_CS/blob/a94c7bd728a2b2b80b016ee86f3310459e872e0d/regamedll/dlls/weapons.h#L420
in general, there are no errors here, then we use only 1 and 0. It would be clearer if it were bool. Using bool m_bPlayEmptySound;

https://github.com/s1lentq/ReGameDLL_CS/blob/a94c7bd728a2b2b80b016ee86f3310459e872e0d/regamedll/dlls/training_gamerules.h#L85-L86
bool m_bSmokeTouching; and bool m_bFlashTouched;
https://github.com/s1lentq/ReGameDLL_CS/blob/a94c7bd728a2b2b80b016ee86f3310459e872e0d/regamedll/dlls/training_gamerules.cpp#L324
bool m_bSmokeTouchingLastFrame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoobWithCheats