Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev build broken in 7.3 with cloudflare #13189

Open
inssein opened this issue Mar 9, 2025 · 3 comments
Open

Dev build broken in 7.3 with cloudflare #13189

inssein opened this issue Mar 9, 2025 · 3 comments
Labels

Comments

@inssein
Copy link

inssein commented Mar 9, 2025

I'm using React Router as a...

framework

Reproduction

When I run npm run dev in mnara-solutions/utiliti.dev#77, and then visit http://localhost:8788/, I get an error.

System Info

➜  utiliti.dev git:(react-router-7-3) npx envinfo --system --npmPackages '{vite,react-router,@react-router/*}' --binaries --browsers

  System:
    OS: macOS 15.3.1
    CPU: (14) arm64 Apple M3 Max
    Memory: 408.80 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.18.0 - ~/.nvm/versions/node/v20.18.0/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v20.18.0/bin/npm
  Browsers:
    Chrome: 133.0.6943.142
    Safari: 18.3
  npmPackages:
    @react-router/cloudflare: ^7.3.0 => 7.3.0
    @react-router/dev: ^7.3.0 => 7.3.0
    react-router: ^7.3.0 => 7.3.0
    vite: ^6.2.1 => 6.2.1

Used Package Manager

npm

Expected Behavior

My project to be viewable at http://localhost:8788/.

Actual Behavior

npm run dev returns the following error after I load my project at http://localhost:8788/:

4:29:57 p.m. [vite] Internal server error: Class extends value undefined is not a constructor or null
      at ../../node_modules/.pnpm/@[email protected]/node_modules/@iarna/toml/lib/create-date.js (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:20627:17)
      at __require (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:12:52)
      at ../../node_modules/.pnpm/@[email protected]/node_modules/@iarna/toml/lib/toml-parser.js (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:20702:22)
      at __require (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:12:52)
      at ../../node_modules/.pnpm/@[email protected]/node_modules/@iarna/toml/parse-string.js (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:22119:22)
      at __require (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:12:52)
      at ../../node_modules/.pnpm/@[email protected]/node_modules/@iarna/toml/parse.js (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:22269:23)
      at __require (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:12:52)
      at ../../node_modules/.pnpm/@[email protected]/node_modules/@iarna/toml/toml.js (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:22555:22)
      at __require (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:12:52)
      at Object.<anonymous> (/Users/inssein/projects/utiliti.dev/node_modules/wrangler/wrangler-dist/cli.js:81889:27)
      at Module._compile (node:internal/modules/cjs/loader:1469:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
      at Module.load (node:internal/modules/cjs/loader:1288:32)
      at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
      at cjsLoader (node:internal/modules/esm/translators:346:17)
      at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
      at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
      at ModuleLoader.import (node:internal/modules/esm/loader:473:24)
      at getContext (/Users/inssein/projects/utiliti.dev/node_modules/@react-router/dev/dist/vite/cloudflare.js:699:36)
      at /Users/inssein/projects/utiliti.dev/node_modules/@react-router/dev/dist/vite/cloudflare.js:714:27 (x4)
@inssein inssein added the bug label Mar 9, 2025
@brophdawg11
Copy link
Contributor

Are you able to trim down to a more minimal reproduction? Running the following to create a new cloudflare app on 7.3.0 looks to work ok for me:

npx create-react-router@latest --template remix-run/react-router-templates/cloudflare

@inssein
Copy link
Author

inssein commented Mar 14, 2025

Let me see if I can compare with the template, the exception stack trace has nothing to do with my code so I probably something else.

@inssein
Copy link
Author

inssein commented Mar 14, 2025

So, that template is cloudflare workers, and looks like my project is slightly behind and still on cloudflare pages. Cloudflare has no migration path yet, so I can’t test it out exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants