Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RR 7.4.0 Borked #13263

Closed
keepforever opened this issue Mar 19, 2025 · 3 comments
Closed

Update to RR 7.4.0 Borked #13263

keepforever opened this issue Mar 19, 2025 · 3 comments
Labels

Comments

@keepforever
Copy link

keepforever commented Mar 19, 2025

I'm using React Router as a...

Framework

Reproduction

npx npm-check-updates --reject "vite, typescript" -u
npm install

System Info

node

Used Package Manager

npm

Expected Behavior

I expect to not have to drop my package.json every time RR upgrades

Actual Behavior

npx npm-check-updates --reject "vite, typescript" -u

Upgrading /Users/briancilenti/Desktop/projects/studio2/package.json
[====================] 66/66 100%

@clerk/react-router ^1.1.5 → ^1.1.6
@react-router/dev ^7.3.0 → ^7.4.0
@react-router/node ^7.3.0 → ^7.4.0
@react-router/serve ^7.3.0 → ^7.4.0
@tvadsai/control-room ^0.338.3 → ^0.338.4
@tvadsai/shopify-api ^0.338.3 → ^0.338.4
@types/react ^19.0.11 → ^19.0.12
react-router ^7.3.0 → ^7.4.0

Run npm install to install new versions.
studio2 [ctrl-room-4●] ni
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: studio-2@undefined
npm error Found: @react-router/[email protected]
npm error node_modules/@react-router/dev
npm error dev @react-router/dev@"^7.4.0" from the root project
npm error
npm error Could not resolve dependency:
npm error dev @react-router/dev@"^7.4.0" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/react-router
npm error peer react-router@"^7.4.0" from @react-router/[email protected]
npm error node_modules/@react-router/dev
npm error dev @react-router/dev@"^7.4.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/briancilenti/.npm/_logs/2025-03-19T17_27_21_214Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/briancilenti/.npm/_logs/2025-03-19T17_27_21_214Z-debug-0.log

@keepforever
Copy link
Author

The fix here is to delete node_modules and package-lock.json and do a clean install, but, I have to imagine there's something internally wrong with react-router because this happened on the last minor version bump as well

@firxworx
Copy link

I had an issue with 7.4.0 too but will file a new issue because even blowing away node_modules and pnpm lockfile in my case did nothing.

@timdorr
Copy link
Member

timdorr commented Mar 20, 2025

I would run npm update instead of just install, as that will get any transient deps updated as well. But regardless of that, this doesn't have anything to do with the library or its packages. I use ncu as well and didn't encounter any problems updating 7.3.0 to 7.4.0

@timdorr timdorr closed this as completed Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants