-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grammarinator-process fails for SQLite and MySQL grammars #40
Comments
Hi @mrigger! After investigating the processed grammars, it seems that both of them are buggy:
With the patches above the fuzzer generation should run without any errors. Please let me know if it worked (or not, ofc). Cheers, |
@mrigger Please note, that the SQLite grammars in the ANTLR grammars-v4 repository possibly have issues - that were mentioned in the PR too - that can negatively influence the effectiveness of test generation. For example, since window functions, aggregate functions, etc., are unreachable, they won't be generated and tested by Grammarinator either. |
@mrigger Is this working now with the latest grammar files? Can we close this issue? |
Thanks a lot for your investigation, explanation, and fixes to the grammar, I really appreciate it! I haven't had time yet to re-check, but it is on my TODO list, and I'll reopen the issue or create a new one if necessary. Thanks again! |
I just tried grammarinator on the SQLite and MySQL grammars from https://github.com/antlr/grammars-v4/tree/master/sql (commit 8dca3622acbea8fce8726c73364af232cb6eacce), but for both of them, the latest version of
grammarinator-process
failed.Is this expected?
The text was updated successfully, but these errors were encountered: