Skip to content

Commit d07a4ff

Browse files
authored
Make src bind readwrite (#2268)
* The writes get discarded by Docker, this allows editable pip installs
1 parent b000c73 commit d07a4ff

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/dockerfile/fast_generator.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ func (g *FastGenerator) installPython(lines []string, tmpDir string) ([]string,
366366
if requirementsFile != "" {
367367
lines = append(lines, "RUN "+strings.Join([]string{
368368
"--mount=from=" + dockercontext.RequirementsBuildContextName + ",target=/buildtmp",
369-
"--mount=type=bind,src=\".\",target=/src",
369+
"--mount=type=bind,src=\".\",target=/src,rw",
370370
UV_CACHE_MOUNT,
371371
}, " ")+" cd /src && UV_CACHE_DIR=\""+UV_CACHE_DIR+"\" UV_LINK_MODE=copy UV_COMPILE_BYTECODE=0 /opt/r8/monobase/run.sh monobase.user --requirements=/buildtmp/"+requirements.RequirementsFile+overridesFlag)
372372
}

pkg/dockerfile/fast_generator_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ func TestGeneratePythonPackages(t *testing.T) {
157157
dockerfile, err := generator.GenerateDockerfileWithoutSeparateWeights()
158158
require.NoError(t, err)
159159
dockerfileLines := strings.Split(dockerfile, "\n")
160-
require.Equal(t, "RUN --mount=from=requirements,target=/buildtmp --mount=type=bind,src=\".\",target=/src --mount=type=cache,target=/srv/r8/monobase/uv/cache,id=uv-cache cd /src && UV_CACHE_DIR=\"/srv/r8/monobase/uv/cache\" UV_LINK_MODE=copy UV_COMPILE_BYTECODE=0 /opt/r8/monobase/run.sh monobase.user --requirements=/buildtmp/requirements.txt", dockerfileLines[5])
160+
require.Equal(t, "RUN --mount=from=requirements,target=/buildtmp --mount=type=bind,src=\".\",target=/src,rw --mount=type=cache,target=/srv/r8/monobase/uv/cache,id=uv-cache cd /src && UV_CACHE_DIR=\"/srv/r8/monobase/uv/cache\" UV_LINK_MODE=copy UV_COMPILE_BYTECODE=0 /opt/r8/monobase/run.sh monobase.user --requirements=/buildtmp/requirements.txt", dockerfileLines[5])
161161
}
162162

163163
func TestGenerateVerboseEnv(t *testing.T) {

0 commit comments

Comments
 (0)