prettier eslint and the like

Author: masad-frost

.editorconfig

@@ -0,0 +1,10 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+
+[*.{js,ts}]
+indent_style = space
+indent_size = 2
+

.eslintignore

@@ -0,0 +1,2 @@
+*.d.ts
+api.js

.eslintrc.js

@@ -0,0 +1,24 @@
+module.exports = {
+  extends: ['airbnb', 'plugin:@typescript-eslint/recommended'],
+  parser: '@typescript-eslint/parser',
+  plugins: ['@typescript-eslint', 'prettier'],
+  settings: {
+    'import/parsers': {
+      '@typescript-eslint/parser': ['.ts'],
+    },
+    'import/resolver': {
+      typescript: {},
+    },
+  },
+  rules: {
+    'import/prefer-default-export': 'off',
+    indent: 'off',
+    '@typescript-eslint/indent': ['error', 2],
+    'max-len': ['error', { code: 120 }],
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/no-non-null-assertion': 'error',
+    'operator-linebreak': 'off',
+    'no-param-reassign': ['error', { props: false }],
+    'object-curly-newline': 'off',
+  },
+};

.prettierrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  trailingComma: 'all',
+  tabWidth: 2,
+  semi: true,
+  singleQuote: true,
+  printWidth: 100,
+  bracketSpacing: true,
+  arrowParens: 'always',
+};

.vscode/settings.json

@@ -0,0 +1 @@
+{ "eslint.validate": ["javascript", { "language": "typescript", "autoFix": true }] }

EIOCompat.ts

@@ -1,3 +1,5 @@
+/* global Event CloseEvent MessageEvent */
+
 import * as eio from 'engine.io-client';
 import * as urllib from 'url';
 
@@ -28,24 +30,41 @@ const readyStateStringToValue = new Map([
   ['closed', 3],
 ]);
 
+Object.keys(readyStateStringToValue);
+
 export class EIOCompat {
-  public onclose: ((ev: CloseEvent) => any) | null;
-  public onerror: ((ev: Event) => any) | null;
-  public onmessage: ((ev: MessageEvent) => any) | null;
-  public onopen: ((ev: Event) => any) | null;
+  public onclose: ((ev: CloseEvent) => unknown) | null;
+
+  public onerror: ((ev: Event) => unknown) | null;
+
+  public onmessage: ((ev: MessageEvent) => unknown) | null;
+
+  public onopen: ((ev: Event) => unknown) | null;
+
   public url: string;
+
   public extensions: string;
+
   public protocol: string;
+
   public bufferedAmount: number;
+
   public binaryType: BinaryType;
+
   public readyState: number;
+
   public incomingSequence: number;
+
   public outOfOrderQueue: { [sequence: number]: ArrayBuffer };
+
   public outgoingSequence: number;
 
   readonly CLOSED = 3;
+
   readonly CLOSING = 2;
+
   readonly OPEN = 1;
+
   readonly CONNECTING = 0;
 
   private eioSocket: eio.Socket;
@@ -78,7 +97,7 @@ export class EIOCompat {
       }
     });
 
-    this.eioSocket.on('close', reason => {
+    this.eioSocket.on('close', (reason) => {
       this.setReadyState();
       if (this.onclose != null) {
         const event = new CloseEvent('close', {
@@ -91,49 +110,52 @@ export class EIOCompat {
       }
     });
 
-    this.eioSocket.on('message', data => {
+    this.eioSocket.on('message', (data) => {
       this.setReadyState();
-      if (this.onmessage != null) {
-        if (typeof data === 'string') {
-          throw new Error('expected data to be ArrayBuffer not string');
-        }
+      if (this.onmessage == null) {
+        return;
+      }
+
+      if (typeof data === 'string') {
+        throw new Error('expected data to be ArrayBuffer not string');
+      }
+
+      const view = new DataView(data);
+      const sequence = view.getUint32(0);
+
+      if (this.incomingSequence !== sequence) {
+        // We didn't get the message we expected
+        // put it in the queue until we get the expected message
+        this.outOfOrderQueue[sequence] = data.slice(sequenceBytesCount);
+
+        return;
+      }
+
+      this.incomingSequence = sequence + 1;
 
-        const view = new DataView(data);
-        const sequence = view.getUint32(0);
+      const message = new MessageEvent('message', {
+        data: data.slice(sequenceBytesCount),
+      });
 
-        if (this.incomingSequence !== sequence) {
-          // We didn't get the message we expected
-          // put it in the queue until we get the expected message
-          this.outOfOrderQueue[sequence] = data.slice(sequenceBytesCount);
+      const onmessage = this.onmessage.bind(this);
 
-          return;
-        }
+      onmessage(message);
 
-        this.incomingSequence = sequence + 1;
+      const queuedSequences = Object.keys(this.outOfOrderQueue);
+      if (queuedSequences.length > 0) {
+        // We got the message we expected but we have other messages
+        // that were out of order and queued up
+        queuedSequences.sort().forEach((seq) => {
+          onmessage(
+            new MessageEvent('message', {
+              data: this.outOfOrderQueue[+seq],
+            }),
+          );
 
-        const message = new MessageEvent('message', {
-          data: data.slice(sequenceBytesCount),
+          this.incomingSequence = +seq + 1;
         });
 
-        this.onmessage.call(this, message);
-
-        const queuedSequences = Object.keys(this.outOfOrderQueue);
-        if (queuedSequences.length > 0) {
-          // We got the message we expected but we have other messages
-          // that were out of order and queued up
-          for (let seq of queuedSequences.sort()) {
-            this.onmessage.call(
-              this,
-              new MessageEvent('message', {
-                data: this.outOfOrderQueue[+seq],
-              }),
-            );
-
-            this.incomingSequence = +seq + 1;
-          }
-
-          this.outOfOrderQueue = {};
-        }
+        this.outOfOrderQueue = {};
       }
     });
 
@@ -147,21 +169,18 @@ export class EIOCompat {
   }
 
   setReadyState() {
-    // @ts-ignore
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore engine.io-client doesn't have typing for readyState :/
     this.readyState = readyStateStringToValue.get(this.eioSocket.readyState);
   }
 
   send(buffer: ArrayBuffer) {
-    const sequencedBuffer = new ArrayBuffer(
-      sequenceBytesCount + buffer.byteLength,
-    );
-    new Uint8Array(sequencedBuffer).set(
-      new Uint8Array(buffer),
-      sequenceBytesCount,
-    );
+    const sequencedBuffer = new ArrayBuffer(sequenceBytesCount + buffer.byteLength);
+    new Uint8Array(sequencedBuffer).set(new Uint8Array(buffer), sequenceBytesCount);
 
     const view = new DataView(sequencedBuffer);
-    view.setUint32(0, this.outgoingSequence++);
+    view.setUint32(0, this.outgoingSequence);
+    this.outgoingSequence += 1;
 
     this.eioSocket.send(sequencedBuffer);
     this.setReadyState();

channel.ts

@@ -1,17 +1,18 @@
-import { api } from './api';
 import { EventEmitter } from 'events';
+import { api } from './api';
 import { createDeferred, Deferred } from './deferred';
 
 class Channel extends EventEmitter {
-  public state:
-    | api.OpenChannelRes.State.CREATED
-    | api.OpenChannelRes.State.ATTACHED
-    | null;
+  public state: api.OpenChannelRes.State.CREATED | api.OpenChannelRes.State.ATTACHED | null;
+
   public id: number | null;
+
   public isOpen: boolean;
 
   private sendQueue: Array<api.ICommand>;
+
   private sendToClient: (cmd: api.Command) => void;
+
   private requestMap: { [ref: string]: Deferred<api.Command> };
 
   constructor() {
@@ -31,7 +32,7 @@ class Channel extends EventEmitter {
    * @param cmdJson shape of a command see [[api.ICommand]]
    */
   public send = (cmdJson: api.ICommand) => {
-    cmdJson['channel'] = this.id;
+    cmdJson.channel = this.id;
     this.sendToClient(api.Command.create(cmdJson));
   };
 
@@ -47,10 +48,10 @@ class Channel extends EventEmitter {
         .toString()
         .split('.')[1],
     ).toString(36);
-    const deferred = createDeferred();
+    const deferred = createDeferred<api.Command>();
     this.requestMap[ref] = deferred;
 
-    cmdJson['ref'] = ref;
+    cmdJson.ref = ref;
     this.send(cmdJson);
 
     return deferred.promise;
@@ -100,11 +101,12 @@ class Channel extends EventEmitter {
     this.state = state;
     this.isOpen = true;
 
-    let cmd;
-    // tslint:disable-next-line no-conditional-assignment
-    while ((cmd = this.sendQueue.shift())) {
+    let cmd = this.sendQueue.shift();
+    while (cmd) {
       // It will set the right channel id and send it
       this.send(cmd);
+
+      cmd = this.sendQueue.shift();
     }
 
     this.emit('open');
@@ -139,10 +141,10 @@ class Channel extends EventEmitter {
    * Called when the channel is or client is closed
    */
   public onClose = () => {
-    for (const ref of Object.keys(this.requestMap)) {
+    Object.keys(this.requestMap).forEach((ref) => {
       this.requestMap[ref].reject(new Error('Channel closed'));
       delete this.requestMap[ref];
-    }
+    });
 
     this.isOpen = false;
     this.emit('close');