Cache Github status token #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozak
approved these changes
Mar 3, 2025
kozak
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're requesting a Github installation access token for every github status update requests.
That's quite spammy for an authentication endpoint. The token is supposed to be cached.
The token is cached in an environment variable.
There was another attempt: #7 , which involved moving all the status updates to one process and caching in memory. However, after implementing it I discovered (via our existing test suite, yay!) that it can't work: we rely on being able to leak the request pipe FD to subprocesses, so we can't wait for commandHandler to finish. So I implemented it the other way.
This PR also adds a mock Github API server and some tests for the commit status functionality. Note: the server doesn't verify any authentication tokens.