fix(job): check response for nil in (*CurlJob).DumpResponse (#117)

Author: reugn

job/curl_job.go

@@ -2,6 +2,7 @@ package job
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net/http"
 	"net/http/httputil"
@@ -69,7 +70,10 @@ func (cu *CurlJob) Description() string {
 func (cu *CurlJob) DumpResponse(body bool) ([]byte, error) {
 	cu.Lock()
 	defer cu.Unlock()
-	return httputil.DumpResponse(cu.response, body)
+	if cu.response != nil {
+		return httputil.DumpResponse(cu.response, body)
+	}
+	return nil, errors.New("response is nil")
 }
 
 // JobStatus returns the status of the CurlJob.

job/job_test.go

@@ -68,6 +68,7 @@ func TestMultipleExecution(t *testing.T) {
 
 	// check very often that we've only run one job
 	ticker := time.NewTicker(2 * time.Millisecond)
+loop:
 	for i := 0; i < 1000; i++ {
 		select {
 		case <-ticker.C:
@@ -76,7 +77,7 @@ func TestMultipleExecution(t *testing.T) {
 			}
 		case <-ctx.Done():
 			t.Error("should not have reached timeout")
-			break
+			break loop
 		}
 	}
 
@@ -122,7 +123,16 @@ func TestCurlJob(t *testing.T) {
 	}
 }
 
-func TestCurlJobDescription(t *testing.T) {
+func TestCurlJob_DumpResponse(t *testing.T) {
+	request, err := http.NewRequest(http.MethodGet, worldtimeapiURL, nil)
+	assert.IsNil(t, err)
+	httpJob := job.NewCurlJob(request)
+	response, err := httpJob.DumpResponse(false)
+	assert.IsNil(t, response)
+	assert.ErrorContains(t, err, "response is nil")
+}
+
+func TestCurlJob_Description(t *testing.T) {
 	postRequest, err := http.NewRequest(
 		http.MethodPost,
 		worldtimeapiURL,