Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better docs about icons #3

Open
pomali opened this issue Oct 31, 2019 · 0 comments
Open

Better docs about icons #3

pomali opened this issue Oct 31, 2019 · 0 comments

Comments

@pomali
Copy link

pomali commented Oct 31, 2019

Had quite a lot debugging around using icons on macOS.

Problem 1

there is no documentation that you need to edit assets/dune (in revery-quick-start repo)
like

(install
    (section bin)
    (package App)
-   (files Roboto-Regular.ttf))
+   (files Roboto-Regular.ttf icon.icns))

Problem 2

documentation uses
"iconFile": "assets/icon.icns"
this doesn't correspond with what gets created when you add icon like I did in dune,
and leads person to expect their assets dir is used, but this is path inside *.App package. Even now I'm not sure if it is path inside Contents/MacOS/ or Conents/Resources but they are symlinked so it probably doesn't matter.

All in all little more docs would help here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant