Skip to content

Commit 9b5b015

Browse files
authored
Merge pull request #224 from reviewdog/add_fail_level
Add fail_level and deduplicate fail_on_error
2 parents 9a66066 + c846bd0 commit 9b5b015

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,15 @@ It's same as `-reporter` flag of reviewdog.
3737
Optional. Filtering mode for the reviewdog command \[`added`,`diff_context`,`file`,`nofilter`\].
3838
Default is added.
3939

40+
### `fail_level`
41+
42+
Optional. If set to `none`, always use exit code 0 for reviewdog. Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
43+
Possible values: [`none`, `any`, `info`, `warning`, `error`]
44+
Default is `none`.
45+
4046
### `fail_on_error`
4147

48+
Deprecated, use `fail_level` instead.
4249
Optional. Exit code for reviewdog when errors are found \[`true`,`false`\]
4350
Default is `false`.
4451

action.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,18 @@ inputs:
2323
Default is added.
2424
required: false
2525
default: 'added'
26+
fail_level:
27+
description: |
28+
If set to `none`, always use exit code 0 for reviewdog. Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
29+
Possible values: [none,any,info,warning,error]
30+
Default is `none`.
31+
default: 'none'
2632
fail_on_error:
2733
description: |
34+
Deprecated, use `fail_level` instead.
2835
Exit code for reviewdog when errors are found [true,false]
2936
Default is `false`.
37+
deprecationMessage: Deprecated, use `fail_level` instead.
3038
required: false
3139
default: 'false'
3240
reviewdog_flags:
@@ -62,6 +70,7 @@ runs:
6270
INPUT_LEVEL: ${{ inputs.level }}
6371
INPUT_REPORTER: ${{ inputs.reporter }}
6472
INPUT_FILTER_MODE: ${{ inputs.filter_mode }}
73+
INPUT_FAIL_LEVEL: ${{ inputs.fail_level }}
6574
INPUT_FAIL_ON_ERROR: ${{ inputs.fail_on_error }}
6675
INPUT_REVIEWDOG_FLAGS: ${{ inputs.reviewdog_flags }}
6776
INPUT_ESLINT_FLAGS: ${{ inputs.eslint_flags }}

script.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ npx --no-install -c "eslint -f="${ESLINT_FORMATTER}" ${INPUT_ESLINT_FLAGS:-'.'}"
2828
-name="${INPUT_TOOL_NAME}" \
2929
-reporter="${INPUT_REPORTER:-github-pr-review}" \
3030
-filter-mode="${INPUT_FILTER_MODE}" \
31+
-fail-level="${INPUT_FAIL_LEVEL}" \
3132
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
3233
-level="${INPUT_LEVEL}" \
3334
${INPUT_REVIEWDOG_FLAGS}

0 commit comments

Comments
 (0)