Skip to content

Commit 29a8d55

Browse files
start to fix issues caused by yanking solid out of revolt.js
Signed-off-by: Jersey <[email protected]>
1 parent d972269 commit 29a8d55

File tree

11 files changed

+34
-1488
lines changed

11 files changed

+34
-1488
lines changed

Diff for: .gitmodules

+5-8
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
[submodule "packages/revolt.js"]
2-
path = packages/revolt.js
3-
url = https://github.com/revoltchat/revolt.js
41
[submodule "components/i18n/locales"]
5-
path = packages/client/components/i18n/locales
6-
url = https://github.com/revoltchat/translations
2+
path = packages/client/components/i18n/locales
3+
url = https://github.com/revoltchat/translations
74
[submodule "packages/client/assets"]
8-
path = packages/client/assets
9-
url = https://github.com/revoltchat/assets
10-
update = none
5+
path = packages/client/assets
6+
url = https://github.com/revoltchat/assets
7+
update = none

Diff for: packages/client/components/ui/components/navigation/channels/ServerSidebar.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ type CategoryData = Omit<API.Category, "channels"> & { channels: Channel[] };
7575
/**
7676
* Display server information and channels
7777
*/
78+
// TODO: fix reactivity here on channel add/edit/delete
7879
export const ServerSidebar = (props: Props) => {
7980
const navigate = useNavigate();
8081
const keybinds = useKeybindActions();

Diff for: packages/client/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,4 +111,4 @@
111111
"zod": "3.23.8"
112112
},
113113
"private": true
114-
}
114+
}

Diff for: packages/client/src/interface/Friends.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ type FriendLists = Accessor<{
7777
/**
7878
* Friends menu
7979
*/
80+
// TODO: fix reactivity
8081
export function Friends() {
8182
const client = useClient();
8283

Diff for: packages/client/src/interface/Home.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ export function HomePage() {
117117

118118
return (
119119
// TODO: i18n
120+
// TODO: reactivity
120121
<Base>
121122
<Header placement="primary">
122123
<HeaderIcon>

Diff for: packages/client/src/interface/Sidebar.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ import { Route, useParams, useSmartParams } from "@revolt/routing";
1010
import { state } from "@revolt/state";
1111
import { HomeSidebar, ServerList, ServerSidebar } from "@revolt/ui";
1212

13+
// TODO: fix reactivity
14+
1315
/**
1416
* Left-most channel navigation sidebar
1517
*/

Diff for: packages/client/src/interface/channels/text/Composition.tsx

+7-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
} from "solid-icons/bi";
77
import { For, Match, Show, Switch, onCleanup, onMount } from "solid-js";
88

9-
import { API, Channel } from "revolt.js";
9+
import { Channel } from "revolt.js";
1010

1111
import { useClient } from "@revolt/client";
1212
import { debounce } from "@revolt/common";
@@ -23,7 +23,10 @@ import {
2323
MessageBox,
2424
MessageReplyPreview,
2525
} from "@revolt/ui";
26-
import { registerKeybindWithPriority, unregisterKeybindWithPriority } from "../../../shared/lib/priorityKeybind";
26+
import {
27+
registerKeybindWithPriority,
28+
unregisterKeybindWithPriority,
29+
} from "../../../shared/lib/priorityKeybind";
2730

2831
interface Props {
2932
/**
@@ -74,7 +77,7 @@ export function MessageComposition(props: Props) {
7477
if (typeof isTyping === "number" && +new Date() < isTyping) return;
7578

7679
const ws = client()!.events;
77-
if (ws.state() === 2) {
80+
if (ws.state === 2) {
7881
isTyping = +new Date() + 2500;
7982
ws.send({
8083
type: "BeginTyping",
@@ -89,7 +92,7 @@ export function MessageComposition(props: Props) {
8992
function stopTyping() {
9093
if (isTyping) {
9194
const ws = client()!.events;
92-
if (ws.state() === 2) {
95+
if (ws.state === 2) {
9396
isTyping = undefined;
9497
ws.send({
9598
type: "EndTyping",

Diff for: packages/client/src/interface/channels/text/MemberSidebar.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { For, Match, Show, Switch, createMemo, onMount } from "solid-js";
1+
import { Match, Show, Switch, createMemo, onMount } from "solid-js";
22

33
import { VirtualContainer } from "@minht11/solid-virtual-container";
44
import { Channel, ServerMember, User } from "revolt.js";
@@ -51,6 +51,8 @@ export function MemberSidebar(props: Props) {
5151
*/
5252
const IGNORE_ALL = ["01F7ZSBSFHQ8TA81725KQCSDDP", "01F80118K1F2EYD9XAMCPQ0BCT"];
5353

54+
// TODO: fix reactivity with revolt.js changes
55+
5456
/**
5557
* Server Member Sidebar
5658
*/

Diff for: packages/client/src/interface/channels/text/TextChannel.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ export function TextChannel(props: ChannelPageProps) {
119119
)
120120
);
121121

122+
// TODO: fix message unread floater, typing indicator, editing messages, member sidebar
123+
122124
return (
123125
<>
124126
<Header placement="primary">

Diff for: packages/revolt.js

-1
This file was deleted.

0 commit comments

Comments
 (0)