alt format escaped player name links

Author: rfresh2

src/main/java/vc/api/model/ProfileData.java

@@ -1,5 +1,7 @@
 package vc.api.model;
 
+import vc.util.DiscordMarkdownEscape;
+
 import java.util.UUID;
 
 public interface ProfileData {
@@ -17,4 +19,16 @@ default String getAvatarURL() {
     default String getHeadURL() {
         return String.format("https://crafthead.net/helm/%s/64", uuid().toString().replace("-", ""));
     }
+
+    default String toDiscordFieldValue() {
+        var nameEscaped = DiscordMarkdownEscape.escape(name());
+        var fmt = "[%s](%s)";
+        if (!nameEscaped.equals(name())) {
+            // discord markdown does not support escaping inside links
+            // well, it does, but the backslashes are always visible so its arguably worse
+            // https://github.com/discord/discord-api-docs/issues/6185
+            fmt = "%s ([link](%s))";
+        }
+        return String.format(fmt, nameEscaped, getNameMCLink(uuid()));
+    }
 }

src/main/java/vc/commands/SlashCommand.java

@@ -30,7 +30,7 @@ default Mono<Message> error(DeferrableInteractionEvent event, final String messa
 
     default EmbedCreateSpec.Builder populateIdentity(final EmbedCreateSpec.Builder builder, ProfileData identity) {
         return builder
-            .addField("Player", "[" + identity.name() + "](" + identity.getNameMCLink(identity.uuid()) + ")", true)
+            .addField("Player", identity.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true);
     }

src/main/java/vc/live/watch/WatchManager.java

@@ -445,7 +445,7 @@ public EmbedCreateSpec joinsWatchEmbed(
         var profile = new ProfileDataImpl(connection.playerName(), connection.playerUuid());
         EmbedCreateSpec embed = EmbedCreateSpec.builder()
             .title("Watched Player Online")
-            .addField("Player", "[" + profile.name() + "](" + profile.getNameMCLink(profile.uuid()) + ")", true)
+            .addField("Player", profile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true)
             .thumbnail(profile.getAvatarURL())
@@ -461,7 +461,7 @@ public EmbedCreateSpec leavesWatchEmbed(
         var profile = new ProfileDataImpl(connection.playerName(), connection.playerUuid());
         EmbedCreateSpec embed = EmbedCreateSpec.builder()
             .title("Watched Player Offline")
-            .addField("Player", "[" + profile.name() + "](" + profile.getNameMCLink(profile.uuid()) + ")", true)
+            .addField("Player", profile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true)
             .thumbnail(profile.getAvatarURL())
@@ -477,7 +477,7 @@ public EmbedCreateSpec chatsWatchEmbed(
         var profile = new ProfileDataImpl(chat.playerName(), chat.playerUuid());
         EmbedCreateSpec embed = EmbedCreateSpec.builder()
             .title("Watched Player Chat")
-            .addField("Player", "[" + profile.name() + "](" + profile.getNameMCLink(profile.uuid()) + ")", true)
+            .addField("Player", profile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true)
             .addField("Message", escape(chat.chat()), false)
@@ -495,7 +495,7 @@ public EmbedCreateSpec chatsKeywordWatchEmbed(
         var profile = new ProfileDataImpl(chat.playerName(), chat.playerUuid());
         EmbedCreateSpec embed = EmbedCreateSpec.builder()
             .title("Watched Keyword in Chat")
-            .addField("Player", "[" + profile.name() + "](" + profile.getNameMCLink(profile.uuid()) + ")", true)
+            .addField("Player", profile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true)
             .addField("Message", escape(chat.chat()), false)
@@ -513,13 +513,13 @@ public EmbedCreateSpec deathsWatchEmbed(
         var profile = new ProfileDataImpl(death.victimPlayerName(), death.victimPlayerUuid());
         var embed = EmbedCreateSpec.builder()
             .title("Watched Player Death")
-            .addField("Victim", "[" + profile.name() + "](" + profile.getNameMCLink(profile.uuid()) + ")", true)
+            .addField("Victim", profile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true);
         if (death.killerPlayerUuid() != null) {
             var killerProfile = new ProfileDataImpl(death.killerPlayerName(), death.killerPlayerUuid());
             embed
-                .addField("Killer", "[" + killerProfile.name() + "](" + killerProfile.getNameMCLink(killerProfile.uuid()) + ")", true)
+                .addField("Killer", killerProfile.toDiscordFieldValue(), true)
                 .addField("\u200B", "\u200B", true)
                 .addField("\u200B", "\u200B", true);
         }
@@ -539,10 +539,10 @@ public EmbedCreateSpec killsWatchEmbed(
         var victimProfile = new ProfileDataImpl(death.victimPlayerName(), death.victimPlayerUuid());
         return EmbedCreateSpec.builder()
             .title("Watched Player Kill")
-            .addField("Killer", "[" + killerProfile.name() + "](" + killerProfile.getNameMCLink(killerProfile.uuid()) + ")", true)
+            .addField("Killer", killerProfile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true)
-            .addField("Victim", "[" + victimProfile.name() + "](" + victimProfile.getNameMCLink(victimProfile.uuid()) + ")", true)
+            .addField("Victim", victimProfile.toDiscordFieldValue(), true)
             .addField("\u200B", "\u200B", true)
             .addField("\u200B", "\u200B", true)
             .addField("Death Message", escape(death.deathMessage()).replace(escape(killerProfile.name()), "**" + escape(killerProfile.name()) + "**"), false)