Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems does't support arm Mac #62

Open
251305060 opened this issue Nov 21, 2020 · 22 comments
Open

It seems does't support arm Mac #62

251305060 opened this issue Nov 21, 2020 · 22 comments

Comments

@251305060
Copy link

t3u-diagnose.txt
I try it on MacBook Air m1, but it looks that the code does't support arm deviceExecuting: /usr/bin/kmutil install --volume-root / --check-rebuild
Not rebuilding KC for arch: 'arm64e'
kmutil done
Executing: /usr/bin/kmutil load -b es.govost.ryan.Thunderbolt3Unblocker
Incompatible architecture: Binary is for x86_64, but needed arch arm64e

@rgov
Copy link
Owner

rgov commented Nov 21, 2020

I don't know if it is possible to support the M1 Macs. Do they support third-party kernel extensions? Apple has been moving to eliminate them for several releases now.

@251305060
Copy link
Author

If third party extensions is blocked, is it have other possibility to unblock tb3. such as add md5 string of 11.0.1 to TB3 enabler
5

@rgov
Copy link
Owner

rgov commented Nov 22, 2020

Other methods of unblocking involve patching the kernel extensions on disk. I don't know if those methods still work. They might, but Apple is continuously adding more protections to the system. You should probably look into getting a supported dock.

@qinyongqiang
Copy link

Other methods of unblocking involve patching the kernel extensions on disk. I don't know if those methods still work. They might, but Apple is continuously adding more protections to the system. You should probably look into getting a supported dock.

I cloned the project and try to compile it in universal mode (support both arm and intel) and it seems that some asm instructions not working, see attached screenshot.
截屏2020-12-07 15 22 11

@rgov
Copy link
Owner

rgov commented Dec 7, 2020

Ah yeah. It does need to be updated for ARM. I do not have an M1 Mac so I am unsure what changes need to be made.

@qinyongqiang
Copy link

Ah yeah. It does need to be updated for ARM. I do not have an M1 Mac so I am unsure what changes need to be made.

Mine is on the way...It seems that the asm mov cr0 or cr3 is only available in Intel. I'm not sure if this instruction could be translated by Rosetta

@rgov
Copy link
Owner

rgov commented Dec 7, 2020

Kernel extensions would not be able to run under Rosetta. (I am still not sure this can be loaded at all.)

Basically the whole xnu_override.c would need to be re-implemented for ARM.

@qinyongqiang
Copy link

Kernel extensions would not be able to run under Rosetta. (I am still not sure this can be loaded at all.)

Basically the whole xnu_override.c would need to be re-implemented for ARM.

It seems that would be quite a lot of working... How can I test if the kext can be loaded in M1?

@Nevin8618
Copy link

HP ZBook ThunderBolt Dock can directily use under M1 MacBook Air without applying this kernel patch, So if you have a M1 chip Mac, you can try plug the dock without patching this driver.

@qinyongqiang
Copy link

HP ZBook ThunderBolt Dock can directily use under M1 MacBook Air without applying this kernel patch, So if you have a M1 chip Mac, you can try plug the dock without patching this driver.

Really? It's a good news. I just got my M1 Air but haven't got a chance to test. I'll have a test and then post updates here.

@Nevin8618
Copy link

Nevin8618 commented Dec 17, 2020

HP ZBook ThunderBolt Dock can directily use under M1 MacBook Air without applying this kernel patch, So if you have a M1 chip Mac, you can try plug the dock without patching this driver.

Really? It's a good news. I just got my M1 Air but haven't got a chance to test. I'll have a test and then post updates here.

I‘ve just tested when I got my M1 Air, and I asked a seller who have this dock on sell. He confirmed that the dock is perfectly supported. All interfaces are perfectly worked. And displayPort can output 4k@60Hz after the dock updated the latest firmware.

@kosztag
Copy link

kosztag commented Dec 19, 2020

Hi, I'm also in this situation. I have MacBook Pro M1, and if you doesn't mind, I would like to test. Could someone share me the fixed code or binary?

@Nevin8618
Copy link

Hi, I'm also in this situation. I have MacBook Pro M1, and if you doesn't mind, I would like to test. Could someone share me the fixed code or binary?

Macs with M1 chip support HP ZBook ThunderBolt Dock natively, and no need for any kernel patch.

@kosztag
Copy link

kosztag commented Dec 19, 2020

Hi, I'm also in this situation. I have MacBook Pro M1, and if you doesn't mind, I would like to test. Could someone share me the fixed code or binary?

Macs with M1 chip support HP ZBook ThunderBolt Dock natively, and no need for any kernel patch.

Ok, but I already have Dell TB16 dock using with my Dell laptop. It would be fine if I can us the same dock for both.

@Nevin8618
Copy link

Hi, I'm also in this situation. I have MacBook Pro M1, and if you doesn't mind, I would like to test. Could someone share me the fixed code or binary?

Macs with M1 chip support HP ZBook ThunderBolt Dock natively, and no need for any kernel patch.

Ok, but I already have Dell TB16 dock using with my Dell laptop. It would be fine if I can us the same dock for both.

TB16 Dock has problems in PD charging. So the problem may not related to the driver or that saying "apple's blocking".

@qinyongqiang
Copy link

Hi, I'm also in this situation. I have MacBook Pro M1, and if you doesn't mind, I would like to test. Could someone share me the fixed code or binary?

Macs with M1 chip support HP ZBook ThunderBolt Dock natively, and no need for any kernel patch.

Do you mean this dock? https://support.hp.com/gb-en/document/c04959218
Interesting...Intel Macs doesn't support this dock yet and patching is must.

@Nevin8618
Copy link

Hi, I'm also in this situation. I have MacBook Pro M1, and if you doesn't mind, I would like to test. Could someone share me the fixed code or binary?

Macs with M1 chip support HP ZBook ThunderBolt Dock natively, and no need for any kernel patch.

Do you mean this dock? https://support.hp.com/gb-en/document/c04959218
Interesting...Intel Macs doesn't support this dock yet and patching is must.

Yes, surely this one. Intel Macs can't support this but M1 Macs can use this without any patching.

@baronmax
Copy link

baronmax commented Jan 1, 2021

Yes I tried the HP ZBook / Elitebook TB3 dock with Macbook M1 and it seemed to work without any patch despite showing as 'unsupported'. I tested the USB connection only as I only have one TB3 cable at present.

@General13K7
Copy link

HP ZBook 150W Thunderbolt 3 Dock this dock is no longer for sale.
So no testing with thunderbolt unlock?

@gencymex
Copy link

gencymex commented Mar 9, 2021

I think that I found out what we need to do to get this running on ARM Macs. According to the Apple Support doc it is possible to run kernel extensions, but not recommended for security purposes.

Once you lower your firmware security level in RecoveryOS, compile the project with Xcode. I haven't taken a look at the xcode project yet, as I have just discovered this awesome repo and wanted to look into the possibility first.

@rgov
Copy link
Owner

rgov commented Mar 9, 2021 via email

@tanpengsccd
Copy link

the

YES ,It work on M1 MBP macOS 11.2.3,but when I unplug my External hard disk from this HP TB3 dock , my MBP Crash and reboot. Are you having this problem?

this Dock:
https://support.hp.com/us-en/drivers/selfservice/hp-zbook-dock-with-thunderbolt-3/11122586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants