Remove needless access() in efivarfs_probe()

The access() is always seemingly-validated by a statfs():
there's no need for this, but this incurs an additional syscall

Signed-off-by: Ahelenia Ziemiańska <[email protected]>

Author: nabijaczleweli

src/efivarfs.c

@@ -69,30 +69,26 @@ efivarfs_probe(void)
 {
 	const char *path = get_efivarfs_path();
 
-	if (!access(path, F_OK)) {
-		int rc = 0;
-		struct statfs buf;
-
-		memset(&buf, '\0', sizeof (buf));
-		rc = statfs(path, &buf);
-		if (rc == 0) {
-			char *tmp;
-			__typeof__(buf.f_type) magic = EFIVARFS_MAGIC;
-			if (!memcmp(&buf.f_type, &magic, sizeof (magic)))
-				return 1;
-			else
-				efi_error("bad fs type for %s", path);
-
-			tmp = getenv("EFIVARFS_PATH");
-			if (tmp && !strcmp(tmp, path)) {
-				efi_error_clear();
-				return 1;
-			}
-		} else {
-			efi_error("statfs(%s) failed", path);
+	int rc = 0;
+	struct statfs buf;
+
+	memset(&buf, '\0', sizeof (buf));
+	rc = statfs(path, &buf);
+	if (rc == 0) {
+		char *tmp;
+		__typeof__(buf.f_type) magic = EFIVARFS_MAGIC;
+		if (!memcmp(&buf.f_type, &magic, sizeof (magic)))
+			return 1;
+		else
+			efi_error("bad fs type for %s", path);
+
+		tmp = getenv("EFIVARFS_PATH");
+		if (tmp && !strcmp(tmp, path)) {
+			efi_error_clear();
+			return 1;
 		}
 	} else {
-		efi_error("access(%s, F_OK) failed", path);
+		efi_error("statfs(%s) failed", path);
 	}
 
 	return 0;