Fix OOB memory access

rheyns · rheyns · commit ee6da8b8dfe0 · 2017-04-03T19:56:02.000-07:00
diff --git a/pyramidal.c b/pyramidal.c
@@ -132,9 +132,11 @@ void shift_and_mark(PACK_T *source, PACK_T *target, unsigned long long length, u
         target[i + access_offset] |= shifted[0];
         target[i + 1 + access_offset] |= shifted[1];
     }
-    i = stop;
-    ext_shift(source[i], bitoff, shifted);
-    target[i + access_offset] |= shifted[0];
+    if (i + access_offset > 0) {
+        i = stop;
+        ext_shift(source[i], bitoff, shifted);
+        target[i + access_offset] |= shifted[0];
+    }
     return;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,11 @@ void shift_and_mark(PACK_T source, PACK_T target, unsigned long long length, u`
`132`	`132`	`target[i + access_offset] \|= shifted[0];`
`133`	`133`	`target[i + 1 + access_offset] \|= shifted[1];`
`134`	`134`	`}`
`135`		`- i = stop;`
`136`		`- ext_shift(source[i], bitoff, shifted);`
`137`		`- target[i + access_offset] \|= shifted[0];`
	`135`	`+ if (i + access_offset > 0) {`
	`136`	`+ i = stop;`
	`137`	`+ ext_shift(source[i], bitoff, shifted);`
	`138`	`+ target[i + access_offset] \|= shifted[0];`
	`139`	`+ }`
`138`	`140`	`return;`
`139`	`141`	`}`
`140`	`142`