Skip to content

Sync telemeter allowlist #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

philipgough
Copy link
Contributor

No description provided.

@philipgough philipgough merged commit e30a9cc into rhobs:main Apr 16, 2025
0 of 2 checks passed
@philipgough philipgough deleted the fix-allowlist branch April 16, 2025 10:47
@juzhao
Copy link
Contributor

juzhao commented Apr 17, 2025

@philipgough
below metrics are shown twice in server allow list, they are with different types

type:tempo_operator_tempostack_multi_tenancy:sum
type:opentelemetry_collector_receivers:sum
type:opentelemetry_collector_exporters:sum
type:opentelemetry_collector_processors:sum
type:opentelemetry_collector_extensions:sum
type:opentelemetry_collector_connectors:sum

example

          - --whitelist={__name__="type:opentelemetry_collector_connectors:sum",type=~"spanmetricsconnector|forwardconnector"}
          - --whitelist={__name__="type:opentelemetry_collector_connectors:sum",type=~"spanmetrics|forward"}

we should leave the second one based on PR
https://github.com/openshift/cluster-monitoring-operator/pull/2583/files
the first one was the original setting, the second one is the PR has been updated, I think we should only keep the second one, but keep them both is also fine, not sure if we have standard for such issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants