Skip to content

Commit 8974830

Browse files
tillkrusstillkruss
committed
drop ignored groups
1 parent 06c71c9 commit 8974830

File tree

4 files changed

+23
-27
lines changed

4 files changed

+23
-27
lines changed

‎CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
- Call `redis_object_cache_error` action before `wp_die()`
1111
- Allow `WP_REDIS_PLUGIN_PATH` to be defined elsewhere
1212
- Added experimental flush timeout (defaults to `5` seconds)
13-
- Swap out ignored `themes` for `theme_json` cache group
13+
- Dropped unnecessary default ignored groups
1414

1515
## 2.4.4
1616

‎README.md

+14-14
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,20 @@ Answers to common questions and troubleshooting of common errors can be found in
2929

3030
The Redis Object Cache plugin comes with vast set of configuration options. If you're unsure how to use them read the [installation instructions](INSTALL.md).
3131

32-
| Configuration constant | Default | Description |
33-
| ------------------------------------ | ------------------------------------- | --------------------------------------------- |
34-
| `WP_REDIS_HOST` | `127.0.0.1` | The hostname of the Redis server |
35-
| `WP_REDIS_PORT` | `6379` | The port of the Redis server |
36-
| `WP_REDIS_PATH` | | The path to the unix socket of the Redis server |
37-
| `WP_REDIS_SCHEME` | `tcp` | The scheme used to connect: `tcp` or `unix` |
38-
| `WP_REDIS_DATABASE` | `0` | The database used by the cache: `0-15` |
39-
| `WP_REDIS_PREFIX` | | The prefix used for all cache keys to avoid data collisions (replaces `WP_CACHE_KEY_SALT`), should be human readable and not a "salt" |
40-
| `WP_REDIS_PASSWORD` | | The password of the Redis server, supports Redis ACLs arrays: `['user', 'password']` |
41-
| `WP_REDIS_MAXTTL` | `0` | The maximum time-to-live of cache keys |
42-
| `WP_REDIS_CLIENT` | | The client used to communicate with Redis (defaults to `phpredis` when installed, otherwise `predis`), supports `phpredis`, `predis`, `relay` |
43-
| `WP_REDIS_TIMEOUT` | `1` | The connection timeout in seconds |
44-
| `WP_REDIS_READ_TIMEOUT` | `1` | The timeout in seconds when reading/writing |
45-
| `WP_REDIS_IGNORED_GROUPS` | `['counts', 'plugins', 'theme_json']` | Groups that should not be cached between requests in Redis |
32+
| Configuration constant | Default | Description |
33+
| ------------------------------------ | ----------- | --------------------------------------------- |
34+
| `WP_REDIS_HOST` | `127.0.0.1` | The hostname of the Redis server |
35+
| `WP_REDIS_PORT` | `6379` | The port of the Redis server |
36+
| `WP_REDIS_PATH` | | The path to the unix socket of the Redis server |
37+
| `WP_REDIS_SCHEME` | `tcp` | The scheme used to connect: `tcp` or `unix` |
38+
| `WP_REDIS_DATABASE` | `0` | The database used by the cache: `0-15` |
39+
| `WP_REDIS_PREFIX` | | The prefix used for all cache keys to avoid data collisions (replaces `WP_CACHE_KEY_SALT`), should be human readable and not a "salt" |
40+
| `WP_REDIS_PASSWORD` | | The password of the Redis server, supports Redis ACLs arrays: `['user', 'password']` |
41+
| `WP_REDIS_MAXTTL` | `0` | The maximum time-to-live of cache keys |
42+
| `WP_REDIS_CLIENT` | | The client used to communicate with Redis (defaults to `phpredis` when installed, otherwise `predis`), supports `phpredis`, `predis`, `relay` |
43+
| `WP_REDIS_TIMEOUT` | `1` | The connection timeout in seconds |
44+
| `WP_REDIS_READ_TIMEOUT` | `1` | The timeout in seconds when reading/writing |
45+
| `WP_REDIS_IGNORED_GROUPS` | `[]` | Groups that should not be cached between requests in Redis |
4646

4747
<details>
4848
<summary>Advanced configuration options</summary>

‎includes/object-cache.php

+1-5
Original file line numberDiff line numberDiff line change
@@ -441,11 +441,7 @@ class WP_Object_Cache {
441441
*
442442
* @var array
443443
*/
444-
public $ignored_groups = [
445-
'counts',
446-
'plugins',
447-
'theme_json',
448-
];
444+
public $ignored_groups = [];
449445

450446
/**
451447
* List of groups and their types.

‎languages/redis-cache.pot

+7-7
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ msgstr ""
99
"MIME-Version: 1.0\n"
1010
"Content-Type: text/plain; charset=UTF-8\n"
1111
"Content-Transfer-Encoding: 8bit\n"
12-
"POT-Creation-Date: 2023-11-16T19:49:00+00:00\n"
12+
"POT-Creation-Date: 2023-11-16T20:42:18+00:00\n"
1313
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
1414
"X-Generator: WP-CLI 2.9.0\n"
1515
"X-Domain: redis-cache\n"
@@ -302,30 +302,30 @@ msgstr ""
302302
msgid "Object cache drop-in could not be updated. Redis server is unreachable: %s"
303303
msgstr ""
304304

305-
#: includes/object-cache.php:2918
305+
#: includes/object-cache.php:2914
306306
msgid "Error establishing a Redis connection"
307307
msgstr ""
308308

309309
#. translators: %s = Formatted wp-config.php file name.
310-
#: includes/object-cache.php:2925
310+
#: includes/object-cache.php:2921
311311
msgid "WordPress is unable to establish a connection to Redis. This means that the connection information in your %s file are incorrect, or that the Redis server is not reachable."
312312
msgstr ""
313313

314-
#: includes/object-cache.php:2930
314+
#: includes/object-cache.php:2926
315315
msgid "Is the correct Redis host and port set?"
316316
msgstr ""
317317

318-
#: includes/object-cache.php:2931
318+
#: includes/object-cache.php:2927
319319
msgid "Is the Redis server running?"
320320
msgstr ""
321321

322322
#. translators: %s = Link to installation instructions.
323-
#: includes/object-cache.php:2936
323+
#: includes/object-cache.php:2932
324324
msgid "If you need help, please read the <a href=\"%s\">installation instructions</a>."
325325
msgstr ""
326326

327327
#. translators: %1$s = Formatted object-cache.php file name, %2$s = Formatted wp-content directory name.
328-
#: includes/object-cache.php:2943
328+
#: includes/object-cache.php:2939
329329
msgid "To disable Redis, delete the %1$s file in the %2$s directory."
330330
msgstr ""
331331

0 commit comments

Comments
 (0)