unserialize values in incr/decr

tillkruss · tillkruss · commit 98a44d1d8085 · 2025-08-06T13:42:03.000-07:00
related to #584 and #575
diff --git a/includes/object-cache.php b/includes/object-cache.php
@@ -2410,7 +2410,7 @@ public function increment( $key, $offset = 1, $group = 'default' ) {
         }
 
         try {
-            $value = (int) $this->parse_redis_response( $this->redis->get( $derived_key ) );
+            $value = (int) $this->parse_redis_response( $this->maybe_unserialize( $this->redis->get( $derived_key )) );
             $value += $offset;
             $result = $this->parse_redis_response( $this->redis->set( $derived_key, $this->maybe_serialize( $value ) ) );
 
@@ -2472,7 +2472,7 @@ public function decrement( $key, $offset = 1, $group = 'default' ) {
         }
 
         try {
-            $value = (int) $this->parse_redis_response( $this->redis->get( $derived_key ) );
+            $value = (int) $this->parse_redis_response( $this->maybe_unserialize( $this->redis->get( $derived_key ) ) );
             $value -= $offset;
             $result = $this->parse_redis_response( $this->redis->set( $derived_key, $this->maybe_serialize( $value ) ) );
 

Original file line number	Diff line number	Diff line change
`@@ -2410,7 +2410,7 @@ public function increment( $key, $offset = 1, $group = 'default' ) {`
`2410`	`2410`	`}`
`2411`	`2411`
`2412`	`2412`	`try {`
`2413`		`- $value = (int) $this->parse_redis_response( $this->redis->get( $derived_key ) );`
	`2413`	`+ $value = (int) $this->parse_redis_response( $this->maybe_unserialize( $this->redis->get( $derived_key )) );`
`2414`	`2414`	`$value += $offset;`
`2415`	`2415`	`$result = $this->parse_redis_response( $this->redis->set( $derived_key, $this->maybe_serialize( $value ) ) );`
`2416`	`2416`
`@@ -2472,7 +2472,7 @@ public function decrement( $key, $offset = 1, $group = 'default' ) {`
`2472`	`2472`	`}`
`2473`	`2473`
`2474`	`2474`	`try {`
`2475`		`- $value = (int) $this->parse_redis_response( $this->redis->get( $derived_key ) );`
	`2475`	`+ $value = (int) $this->parse_redis_response( $this->maybe_unserialize( $this->redis->get( $derived_key ) ) );`
`2476`	`2476`	`$value -= $offset;`
`2477`	`2477`	`$result = $this->parse_redis_response( $this->redis->set( $derived_key, $this->maybe_serialize( $value ) ) );`
`2478`	`2478`