Skip to content

Saving and Loading Progress Bar #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobbyV2
Copy link
Contributor

@RobbyV2 RobbyV2 commented Jul 20, 2025

Adds a progress bar when saving/loading
Some notes:

  • Z-Index from 50 to 60 so you can see it while on the settings modal
  • To my testing audio exporting still works (as I modified some of the progress logic)
Screen.Recording.2025-07-19.202106.mp4

I appreciate how fast you are with these PRs! Can't express how useful this project has been for me :)

Copy link

vercel bot commented Jul 20, 2025

@RobbyV2 is attempting to deploy a commit to the richardr1126's projects Team on Vercel.

A member of the Team first needs to authorize it.

@RobbyV2 RobbyV2 force-pushed the feat/SaveLoadProgress branch from 6c77d78 to 32f5cdc Compare July 20, 2025 03:22
@richardr1126
Copy link
Owner

richardr1126 commented Jul 20, 2025

What does cancel and download do here? In the exporting it will finish converting the current page and download what's been generated.

Does it just finish downloading the current document?

@richardr1126
Copy link
Owner

Great by the way

@RobbyV2
Copy link
Contributor Author

RobbyV2 commented Jul 20, 2025

What does cancel and download do here? In the exporting it will finish converting the current page and download what's been generated.

Does it finish downloading the current document?

I just noticed that as well; I believe that's due to the cancel and download being re-used from the audio exporting. I'll add another flag to distinguish between the two now.
But as for the button, it simply cancels the upload/download completely.

@richardr1126
Copy link
Owner

Yeah for this version it could just say cancel then

@RobbyV2
Copy link
Contributor Author

RobbyV2 commented Jul 20, 2025

Just pushed a change that addresses this. Should be good now 👍.

Screen.Recording.2025-07-19.212037.mp4

@RobbyV2 RobbyV2 force-pushed the feat/SaveLoadProgress branch from d6df3bf to 7b703f0 Compare July 20, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants