Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vfirst and vcpop return types unexpectedly changed #342

Closed
nick-knight opened this issue Jun 10, 2024 · 1 comment · Fixed by #343
Closed

vfirst and vcpop return types unexpectedly changed #342

nick-knight opened this issue Jun 10, 2024 · 1 comment · Fixed by #343
Assignees
Labels
Resolve for v1.0 Feature or problems we will close before the v1.0 release

Comments

@nick-knight
Copy link
Collaborator

(Cross-posting #287 (comment) to a new issue.)

In #287, the return values for the vcpop and vfirst intrinsics were switched from unsigned long and long to unsigned int and int, while the implementations in upstream LLVM and GCC still have the former types. This API change appears to have been made in this PR, with the following justification:

Replace float16_t with _Float16 that is now supported by both LLVM and GCC. This keeps us away from the need to define our own type. (Resolves #31, and alongside also resolves #166.

FP16 is not relevant to those two issues, and the change made in this PR was not the agreed-upon solution to those issues. (I don't know if we had even come to a consensus: I had argued for a different solution altogether.)

At this point, I suggest we just revert this part of #287.

@nick-knight nick-knight changed the title vfirst and vcpop return types unexpectedly changed vfirst and vcpop return types unexpectedly changed Jun 10, 2024
@nick-knight nick-knight added the Resolve for v1.0 Feature or problems we will close before the v1.0 release label Jun 10, 2024
@rofirrim
Copy link
Collaborator

rofirrim commented Jun 13, 2024

Cherry-picked into v1.0.x

ca4156a
4ba136c
eccc2e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolve for v1.0 Feature or problems we will close before the v1.0 release
Projects
None yet
4 participants