Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-riscv-intc.c:158 irq_enable+0x32/0x58 #130

Open
michaeljclark opened this issue Feb 25, 2018 · 4 comments
Open

WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-riscv-intc.c:158 irq_enable+0x32/0x58 #130

michaeljclark opened this issue Feb 25, 2018 · 4 comments

Comments

@michaeljclark
Copy link
Contributor

Kernel warning when booting riscv-linux-4.15 branch in latest QEMU with SMP enabled.

static void riscv_irq_enable(struct irq_data *d)
{
        struct riscv_irq_data *data = irq_data_get_irq_chip_data(d);

        /*
         * It's only possible to write SIE on the current hart.  This jumps
         * over to the target hart if it's not the current one.  It's invalid
         * to write SIE on a hart that's not currently running.
         */
        if (data->hart == smp_processor_id())
                riscv_irq_unmask(d);
        else if (cpu_online(data->hart))
                riscv_remote_ctrl(data->hart, riscv_irq_enable_helper, d);
        else
                WARN_ON_ONCE(1); // <- this warning is triggering 
}

It warns only once, so we don't know how often it is triggering. The kernel appears stable.

$ sudo ./riscv64-softmmu/qemu-system-riscv64 -smp cpus=4 -nographic -machine virt -kernel qemu-images/bbl-4.15 -append "root=/dev/vda ro" -drive file=qemu-images/busybear.bin,format=raw,id=hd0 -device virtio-blk-device,drive=hd0 -netdev type=tap,script=./qemu-images/ifup.macos,downscript=./qemu-images/ifdown.macos,id=net0 -device virtio-net-device,netdev=net0
[    0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80200000
[    0.000000] Linux version 4.15.0-00050-g55f79e25d599 (mclark@minty) (gcc version 7.1.1 20170509 (GCC)) #96 SMP Mon Feb 26 09:20:44 NZDT 2018
[    0.000000] bootconsole [early0] enabled
[    0.000000] Zone ranges:
[    0.000000]   DMA32    [mem 0x0000000080200000-0x0000000087ffffff]
[    0.000000]   Normal   [mem 0x0000000088000000-0x0000087fffffffff]
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000080200000-0x0000000087ffffff]
[    0.000000] Initmem setup node 0 [mem 0x0000000080200000-0x0000000087ffffff]
[    0.000000] software IO TLB [mem 0x83e3b000-0x87e3b000] (64MB) mapped at [        (ptrval)-        (ptrval)]
[    0.000000] elf_hwcap is 0x112d
[    0.000000] percpu: Embedded 14 pages/cpu @        (ptrval) s24600 r0 d32744 u57344
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 31815
[    0.000000] Kernel command line: root=/dev/vda ro
[    0.000000] Dentry cache hash table entries: 16384 (order: 5, 131072 bytes)
[    0.000000] Inode-cache hash table entries: 8192 (order: 4, 65536 bytes)
[    0.000000] Sorting __ex_table...
[    0.000000] Memory: 57404K/129024K available (2245K kernel code, 163K rwdata, 563K rodata, 124K init, 266K bss, 71620K reserved, 0K cma-reserved)
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
[    0.000000] Hierarchical RCU implementation.
[    0.000000] 	RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=4.
[    0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=4
[    0.000000] NR_IRQS: 0, nr_irqs: 0, preallocated irqs: 0
[    0.000000] riscv,cpu_intc,0: 64 local interrupts mapped
[    0.000000] riscv,cpu_intc,1: 64 local interrupts mapped
[    0.000000] riscv,cpu_intc,2: 64 local interrupts mapped
[    0.000000] riscv,cpu_intc,3: 64 local interrupts mapped
[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-riscv-intc.c:158 irq_enable+0x32/0x58
[    0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.15.0-00050-g55f79e25d599 #96
[    0.000000] Call Trace:
[    0.000000] [<        (ptrval)>] walk_stackframe+0x0/0x7e
[    0.000000] [<        (ptrval)>] dump_stack+0x5a/0x76
[    0.000000] [<        (ptrval)>] __warn+0xc0/0xda
[    0.000000] [<        (ptrval)>] irq_enable+0x2e/0x58
[    0.000000] [<        (ptrval)>] __irq_startup+0x82/0x8a
[    0.000000] [<        (ptrval)>] irq_startup+0x4c/0xf4
[    0.000000] [<        (ptrval)>] plic_irq_disable+0x6e/0x72
[    0.000000] [<        (ptrval)>] irq_set_chained_handler_and_data+0x24/0x42
[    0.000000] [<        (ptrval)>] plic_init+0x1e6/0x312
[    0.000000] [<        (ptrval)>] printk+0x1e/0x28
[    0.000000] [<        (ptrval)>] riscv_intc_init+0xc6/0xf4
[    0.000000] [<        (ptrval)>] of_irq_init+0x112/0x206
[    0.000000] [<        (ptrval)>] start_kernel+0x22c/0x354
[    0.000000] random: get_random_bytes called from print_oops_end_marker+0x36/0x4e with crng_init=0
[    0.000000] ---[ end trace 811f0666af6c5eb2 ]---
[    0.000000] riscv,plic0,c000000: mapped 10 interrupts to 4/8 handlers
[    0.000000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x24e6a1710, max_idle_ns: 440795202120 ns
[    0.000000] Calibrating delay loop (skipped), value calculated using timer frequency.. 20.00 BogoMIPS (lpj=100000)
[    0.000000] pid_max: default: 32768 minimum: 301
[    0.000000] Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
[    0.000000] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes)
[    0.040000] Hierarchical SRCU implementation.
[    0.050000] smp: Bringing up secondary CPUs ...
[    0.050000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x24e6a1710, max_idle_ns: 440795202120 ns
[    0.070000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x24e6a1710, max_idle_ns: 440795202120 ns
[    0.070000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x24e6a1710, max_idle_ns: 440795202120 ns
[    0.080000] smp: Brought up 1 node, 4 CPUs
[    0.130000] devtmpfs: initialized
[    0.140000] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
[    0.140000] futex hash table entries: 1024 (order: 4, 65536 bytes)
[    0.150000] NET: Registered protocol family 16
[    0.170000] vgaarb: loaded
[    0.190000] clocksource: Switched to clocksource riscv_clocksource
[    0.200000] NET: Registered protocol family 2
[    0.200000] TCP established hash table entries: 1024 (order: 1, 8192 bytes)
[    0.200000] TCP bind hash table entries: 1024 (order: 2, 16384 bytes)
[    0.200000] TCP: Hash tables configured (established 1024 bind 1024)
[    0.210000] UDP hash table entries: 256 (order: 1, 8192 bytes)
[    0.220000] UDP-Lite hash table entries: 256 (order: 1, 8192 bytes)
[    0.230000] NET: Registered protocol family 1
[    0.250000] workingset: timestamp_bits=62 max_order=14 bucket_order=0
[    0.300000] random: fast init done
[    0.370000] io scheduler noop registered
[    0.370000] io scheduler cfq registered (default)
[    0.380000] io scheduler mq-deadline registered
[    0.380000] io scheduler kyber registered
[    0.950000] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
[    0.980000] console [ttyS0] disabled
[    0.980000] 10000000.uart: ttyS0 at MMIO 0x10000000 (irq = 13, base_baud = 230400) is a 16550A
[    0.980000] console [ttyS0] enabled
[    0.980000] console [ttyS0] enabled
[    0.990000] bootconsole [early0] disabled
[    0.990000] bootconsole [early0] disabled
[    1.190000] EXT4-fs (vda): couldn't mount as ext3 due to feature incompatibilities
[    1.200000] EXT4-fs (vda): couldn't mount as ext2 due to feature incompatibilities
[    1.220000] EXT4-fs (vda): INFO: recovery required on readonly filesystem
[    1.220000] EXT4-fs (vda): write access will be enabled during recovery
[    1.370000] EXT4-fs (vda): recovery complete
[    1.380000] EXT4-fs (vda): mounted filesystem with ordered data mode. Opts: (null)
[    1.390000] VFS: Mounted root (ext4 filesystem) readonly on device 254:0.
[    1.400000] devtmpfs: mounted
[    1.410000] Freeing unused kernel memory: 124K
[    1.410000] This architecture does not have kernel memory protection.
[    2.640000] EXT4-fs (vda): re-mounted. Opts: data=ordered
Initializing mdev...

ucbvax login: root
Password: ntpd: setting time to 2018-02-25 20:23:36.617367 (offset +1519590206.408055s)

    ____                   ____                     __    _                 
   / __ )__  _________  __/ __ )___  ____ ______   / /   (_)___  __  ___  __
  / __  / / / / ___/ / / / __  / _ \/ __ `/ ___/  / /   / / __ \/ / / / |/_/
 / /_/ / /_/ (__  ) /_/ / /_/ /  __/ /_/ / /     / /___/ / / / / /_/ />  <  
/_____/\__,_/____/\__, /_____/\___/\__,_/_/     /_____/_/_/ /_/\__,_/_/|_|  
                 /____/                                                     
root@ucbvax:~# 
root@ucbvax:~# 
root@ucbvax:~# cat /proc/cpuinfo 
hart	: 0
isa	: rv64imafdc
mmu	: sv48

hart	: 1
isa	: rv64imafdc
mmu	: sv48

hart	: 2
isa	: rv64imafdc
mmu	: sv48

hart	: 3
isa	: rv64imafdc
mmu	: sv48

root@ucbvax:~#
@sorear
Copy link
Contributor

sorear commented Feb 26, 2018

Fedora has seen the same warning. We haven't investigated it since, as you say, the kernel appears stable.

@michaeljclark
Copy link
Contributor Author

I'm getting the same message on linux-kernel-4.14 running on the RTL on VC707 FPGA

[    0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80200000
[    0.000000] Linux version 4.14.0-00030-gc2d852c ([email protected]) (gcc version 7.2.0 (GCC)) #1 SMP Tue Dec 19 16:13:56 P7
[    0.000000] bootconsole [early0] enabled
[    0.000000] Initial ramdisk at: 0xffffffe00001e200 (5672960 bytes)
[    0.000000] Zone ranges:
[    0.000000]   DMA      [mem 0x0000000080200000-0x00000000bfffffff]
[    0.000000]   Normal   empty
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000080200000-0x00000000bfffffff]
[    0.000000] Initmem setup node 0 [mem 0x0000000080200000-0x00000000bfffffff]
[    0.000000] On node 0 totalpages: 261632
[    0.000000] free_area_init_node: node 0, pgdat ffffffe0009425c0, node_mem_map ffffffe03f007000
[    0.000000]   DMA zone: 3577 pages used for memmap
[    0.000000]   DMA zone: 0 pages reserved
[    0.000000]   DMA zone: 261632 pages, LIFO batch:31
[    0.000000] CPU with hartid=0 has a non-okay status of "masked"
[    0.000000] elf_hwcap is 0x1105
[    0.000000] percpu: Embedded 14 pages/cpu @ffffffe03efbd000 s28376 r0 d28968 u57344
[    0.000000] pcpu-alloc: s28376 r0 d28968 u57344 alloc=14*4096
[    0.000000] pcpu-alloc: [0] 1 [0] 2 [0] 3 [0] 4 
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 258055
[    0.000000] Kernel command line: earlyprintk 
[    0.000000] PID hash table entries: 4096 (order: 3, 32768 bytes)
[    0.000000] Dentry cache hash table entries: 131072 (order: 8, 1048576 bytes)
[    0.000000] Inode-cache hash table entries: 65536 (order: 7, 524288 bytes)
[    0.000000] Sorting __ex_table...
[    0.000000] Memory: 1020056K/1046528K available (2826K kernel code, 236K rwdata, 746K rodata, 5695K init, 774K bss, 26472K reserved, 0K )
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=5, Nodes=1
[    0.000000] Hierarchical RCU implementation.
[    0.000000]  RCU event tracing is enabled.
[    0.000000]  RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=5.
[    0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=5
[    0.000000] NR_IRQS: 0, nr_irqs: 0, preallocated irqs: 0
[    0.000000] CPU with hartid=0 has a non-okay status of "masked"
[    0.000000] riscv,cpu_intc,1: 64 local interrupts mapped
[    0.000000] riscv,cpu_intc,2: 64 local interrupts mapped
[    0.000000] riscv,cpu_intc,3: 64 local interrupts mapped
[    0.000000] riscv,cpu_intc,4: 64 local interrupts mapped
[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: CPU: 1 PID: 0 at /scratch/hes/freedom-u-sdk/linux/drivers/irqchip/irq-riscv-intc.c:157 riscv_irq_enable+0x92/0x94
[    0.000000] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.14.0-00030-gc2d852c #1
[    0.000000] Call Trace:
[    0.000000] [<ffffffe000591bfa>] walk_stackframe+0x0/0xa2
[    0.000000] [<ffffffe000591d38>] show_stack+0x26/0x34
[    0.000000] [<ffffffe00083e06e>] dump_stack+0x5e/0x7c
[    0.000000] [<ffffffe000594ef2>] __warn+0xbe/0xd4
[    0.000000] [<ffffffe000594f82>] warn_slowpath_null+0x10/0x1c
[    0.000000] [<ffffffe0006e6bde>] riscv_irq_enable+0x8e/0x94
[    0.000000] [<ffffffe0005c8104>] irq_enable+0x3a/0x6a
[    0.000000] [<ffffffe0005c817e>] __irq_startup+0x4a/0x52
[    0.000000] [<ffffffe0005c81d6>] irq_startup+0x50/0xda
[    0.000000] [<ffffffe0005c82d0>] __irq_do_set_handler+0x70/0x136
[    0.000000] [<ffffffe0005c8d0e>] irq_set_chained_handler_and_data+0x2c/0x4a
[    0.000000] [<ffffffe0006e6814>] plic_init+0x1f6/0x322
[    0.000000] [<ffffffe000011cd0>] of_irq_init+0x136/0x252
[    0.000000] [<ffffffe00000c7e6>] irqchip_init+0x10/0x1c
[    0.000000] [<ffffffe0000021dc>] init_IRQ+0x8/0x14
[    0.000000] [<ffffffe0000008e0>] start_kernel+0x20a/0x348
[    0.000000] [<ffffffe00000004e>] _sinittext+0x4e/0x56
[    0.000000] random: get_random_bytes called from print_oops_end_marker+0x3a/0x52 with crng_init=0
[    0.000000] ---[ end trace 242ad3eb94620356 ]---
[    0.000000] riscv,plic0,c000000: mapped 18 interrupts to 4/9 handlers
[    0.000000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x1d854df40, max_idle_ns: 3526361616960 ns
[    0.000000] console [hvc0] enabled
[    0.000000] bootconsole [early0] disabled
[    0.010000] Calibrating delay loop (skipped), value calculated using timer frequency.. 2.00 BogoMIPS (lpj=10000)
[    0.020000] pid_max: default: 32768 minimum: 301
[    0.020000] Mount-cache hash table entries: 2048 (order: 2, 16384 bytes)
[    0.030000] Mountpoint-cache hash table entries: 2048 (order: 2, 16384 bytes)
[    0.070000] Hierarchical SRCU implementation.
[    0.090000] smp: Bringing up secondary CPUs ...
[    0.110000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x1d854df40, max_idle_ns: 3526361616960 ns
[    0.130000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x1d854df40, max_idle_ns: 3526361616960 ns
[    0.140000] clocksource: riscv_clocksource: mask: 0xffffffffffffffff max_cycles: 0x1d854df40, max_idle_ns: 3526361616960 ns
[    0.150000] smp: Brought up 1 node, 4 CPUs
[    0.200000] devtmpfs: initialized
[    0.270000] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
[    0.280000] futex hash table entries: 1024 (order: 4, 65536 bytes)
[    0.300000] NET: Registered protocol family 16
[    0.540000] vgaarb: loaded
[    0.550000] SCSI subsystem initialized
[    0.560000] libata version 3.00 loaded.
[    0.560000] usbcore: registered new interface driver usbfs
[    0.570000] usbcore: registered new interface driver hub
[    0.570000] usbcore: registered new device driver usb
[    0.580000] pps_core: LinuxPPS API ver. 1 registered
[    0.580000] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti <[email protected]>
[    0.590000] PTP clock support registered
[    0.600000] clocksource: Switched to clocksource riscv_clocksource
[    0.640000] NET: Registered protocol family 2
[    0.670000] TCP established hash table entries: 8192 (order: 4, 65536 bytes)
[    0.680000] TCP bind hash table entries: 8192 (order: 5, 131072 bytes)
[    0.690000] TCP: Hash tables configured (established 8192 bind 8192)
[    0.710000] UDP hash table entries: 512 (order: 2, 16384 bytes)
[    0.720000] UDP-Lite hash table entries: 512 (order: 2, 16384 bytes)
[    0.730000] NET: Registered protocol family 1
[    0.740000] PCI: CLS 0 bytes, default 64
[    2.230000] Unpacking initramfs...
[    3.870000] workingset: timestamp_bits=62 max_order=18 bucket_order=0
[    4.150000] random: fast init done
[    4.240000] io scheduler noop registered
[    4.260000] io scheduler cfq registered (default)
[    4.260000] io scheduler mq-deadline registered
[    4.270000] io scheduler kyber registered
[    4.310000] xilinx-pcie 50000000.pci: PCIe Link is UP
[    4.310000] OF: PCI: host bridge /soc/pci@50000000 ranges:
[    4.320000] OF: PCI:   No bus range found for /soc/pci@50000000, using [bus 00-ff]
[    4.330000] OF: PCI:   MEM 0x60000000..0x7fffffff -> 0x60000000
[    4.340000] xilinx-pcie 50000000.pci: PCI host bridge to bus 0000:00
[    4.340000] pci_bus 0000:00: root bus resource [bus 00-ff]
[    4.350000] pci_bus 0000:00: root bus resource [mem 0x60000000-0x7fffffff]
[    4.360000] pci_bus 0000:00: scanning bus
[    4.360000] pci 0000:00:00.0: [10ee:7111] type 01 class 0x060400
[    4.360000] pci 0000:00:00.0: enabling Extended Tags
[    4.370000] pci_bus 0000:00: fixups for bus
[    4.370000] pci 0000:00:00.0: scanning [bus 00-00] behind bridge, pass 0
[    4.370000] pci 0000:00:00.0: bridge configuration invalid ([bus 00-00]), reconfiguring
[    4.380000] pci 0000:00:00.0: scanning [bus 00-00] behind bridge, pass 1
[    4.380000] pci_bus 0000:01: scanning bus
[    4.380000] pci 0000:01:00.0: [8086:10d3] type 00 class 0x020000
[    4.380000] pci 0000:01:00.0: calling quirk_f0_vpd_link+0x0/0x5c
[    4.380000] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x0001ffff]
[    4.380000] pci 0000:01:00.0: reg 0x14: [mem 0x00000000-0x0007ffff]
[    4.380000] pci 0000:01:00.0: reg 0x18: [io  0x0000-0x001f]
[    4.380000] pci 0000:01:00.0: reg 0x1c: [mem 0x00000000-0x00003fff]
[    4.380000] pci 0000:01:00.0: reg 0x30: [mem 0x00000000-0x0003ffff pref]
[    4.390000] pci 0000:01:00.0: PME# supported from D0 D3hot D3cold
[    4.390000] pci 0000:01:00.0: PME# disabled
[    4.390000] pci_bus 0000:01: fixups for bus
[    4.390000] pci_bus 0000:01: bus scan returning with max=01
[    4.390000] pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01
[    4.390000] pci_bus 0000:00: bus scan returning with max=01
[    4.390000] pci 0000:00:00.0: BAR 8: assigned [mem 0x60000000-0x600fffff]
[    4.400000] pci 0000:00:00.0: BAR 7: no space for [io  size 0x1000]
[    4.410000] pci 0000:00:00.0: BAR 7: failed to assign [io  size 0x1000]
[    4.410000] pci 0000:01:00.0: BAR 1: assigned [mem 0x60000000-0x6007ffff]
[    4.420000] pci 0000:01:00.0: BAR 6: assigned [mem 0x60080000-0x600bffff pref]
[    4.430000] pci 0000:01:00.0: BAR 0: assigned [mem 0x600c0000-0x600dffff]
[    4.440000] pci 0000:01:00.0: BAR 3: assigned [mem 0x600e0000-0x600e3fff]
[    4.440000] pci 0000:01:00.0: BAR 2: no space for [io  size 0x0020]
[    4.450000] pci 0000:01:00.0: BAR 2: failed to assign [io  size 0x0020]
[    4.460000] pci 0000:00:00.0: PCI bridge to [bus 01]
[    4.460000] pci 0000:00:00.0:   bridge window [mem 0x60000000-0x600fffff]
[    4.470000] pci 0000:01:00.0: calling quirk_e100_interrupt+0x0/0x15e
[    6.250000] e1000e: Intel(R) PRO/1000 Network Driver - 3.2.6-k
[    6.260000] e1000e: Copyright(c) 1999 - 2015 Intel Corporation.
[    6.270000] e1000e 0000:01:00.0: assign IRQ: got 23
[    6.270000] pci 0000:00:00.0: enabling device (0000 -> 0002)
[    6.280000] pci 0000:00:00.0: enabling bus mastering
[    6.280000] e1000e 0000:01:00.0: enabling device (0000 -> 0002)
[    6.280000] e1000e 0000:01:00.0: enabling bus mastering
[    6.290000] e1000e 0000:01:00.0: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
[    6.400000] e1000e 0000:01:00.0 0000:01:00.0 (uninitialized): registered PHC clock
[    6.530000] e1000e 0000:01:00.0 eth0: (PCI Express:2.5GT/s:Width x1) 00:1b:21:24:12:33
[    6.540000] e1000e 0000:01:00.0 eth0: Intel(R) PRO/1000 Network Connection
[    6.540000] e1000e 0000:01:00.0 eth0: MAC: 3, PHY: 8, PBA No: E46981-003
[    6.560000] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
[    6.560000] ehci-pci: EHCI PCI platform driver
[    6.570000] usbcore: registered new interface driver usb-storage
[    6.580000] IR NEC protocol handler initialized
[    6.580000] IR RC5(x/sz) protocol handler initialized
[    6.590000] IR RC6 protocol handler initialized
[    6.590000] IR JVC protocol handler initialized
[    6.600000] IR Sony protocol handler initialized
[    6.600000] IR SANYO protocol handler initialized
[    6.610000] IR Sharp protocol handler initialized
[    6.610000] IR MCE Keyboard/mouse protocol handler initialized
[    6.620000] IR XMP protocol handler initialized
[    6.630000] usbcore: registered new interface driver usbhid
[    6.630000] usbhid: USB HID core driver
[    6.640000] NET: Registered protocol family 17
[    6.960000] Freeing unused kernel memory: 5692K
[    6.970000] This architecture does not have kernel memory protection.
[   34.850000] e1000e: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx

@palmer-dabbelt
Copy link
Contributor

This isn't a scary warning, it's just a bit of cleanup I need to do related to how we initialize our interrupt stuff.

palmer-dabbelt pushed a commit that referenced this issue Mar 7, 2018
md/raid1: fix NULL pointer dereference
3de59bb 
In handle_write_finished(), if r1_bio->bios[m] != NULL, it thinks
the corresponding conf->mirrors[m].rdev is also not NULL. But, it
is not always true.

Even if some io hold replacement rdev(i.e. rdev->nr_pending.count > 0),
raid1_remove_disk() can also set the rdev as NULL. That means,
bios[m] != NULL, but mirrors[m].rdev is NULL, resulting in NULL
pointer dereference in handle_write_finished and sync_request_write.

This patch can fix BUGs as follows:

 BUG: unable to handle kernel NULL pointer dereference at 0000000000000140
 IP: [<ffffffff815bbbbd>] raid1d+0x2bd/0xfc0
 PGD 12ab52067 PUD 12f587067 PMD 0
 Oops: 0000 [#1] SMP
 CPU: 1 PID: 2008 Comm: md3_raid1 Not tainted 4.1.44+ #130
 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1.fc26 04/01/2014
 Call Trace:
  ? schedule+0x37/0x90
  ? prepare_to_wait_event+0x83/0xf0
  md_thread+0x144/0x150
  ? wake_atomic_t_function+0x70/0x70
  ? md_start_sync+0xf0/0xf0
  kthread+0xd8/0xf0
  ? kthread_worker_fn+0x160/0x160
  ret_from_fork+0x42/0x70
  ? kthread_worker_fn+0x160/0x160

 BUG: unable to handle kernel NULL pointer dereference at 00000000000000b8
 IP: sync_request_write+0x9e/0x980
 PGD 800000007c518067 P4D 800000007c518067 PUD 8002b067 PMD 0
 Oops: 0000 [#1] SMP PTI
 CPU: 24 PID: 2549 Comm: md3_raid1 Not tainted 4.15.0+ #118
 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1.fc26 04/01/2014
 Call Trace:
  ? sched_clock+0x5/0x10
  ? sched_clock_cpu+0xc/0xb0
  ? flush_pending_writes+0x3a/0xd0
  ? pick_next_task_fair+0x4d5/0x5f0
  ? __switch_to+0xa2/0x430
  raid1d+0x65a/0x870
  ? find_pers+0x70/0x70
  ? find_pers+0x70/0x70
  ? md_thread+0x11c/0x160
  md_thread+0x11c/0x160
  ? finish_wait+0x80/0x80
  kthread+0x111/0x130
  ? kthread_create_worker_on_cpu+0x70/0x70
  ? do_syscall_64+0x6f/0x190
  ? SyS_exit_group+0x10/0x10
  ret_from_fork+0x35/0x40

Reviewed-by: NeilBrown <[email protected]>
Signed-off-by: Yufen Yu <[email protected]>
Signed-off-by: Shaohua Li <[email protected]>
@atishp04
Copy link
Contributor

atishp04 commented Nov 2, 2018

This issue is no longer present after we got rid of local interrupt controller driver in 4.19. We can close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sorear @michaeljclark @palmer-dabbelt @atishp04