Skip to content

Commit 1a15906

Browse files
fix: remove column id check (#17494) (#17496)
Signed-off-by: tabVersion <[email protected]> Co-authored-by: Bohan Zhang <[email protected]>
1 parent e61b27e commit 1a15906

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

src/frontend/src/handler/create_source.rs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -492,28 +492,6 @@ pub(crate) async fn bind_columns_from_source(
492492
}
493493
};
494494

495-
if cfg!(debug_assertions) {
496-
// validate column ids
497-
// Note: this just documents how it works currently. It doesn't mean whether it's reasonable.
498-
if let Some(ref columns) = columns {
499-
let mut i = 1;
500-
fn check_col(col: &ColumnDesc, i: &mut usize, columns: &Vec<ColumnCatalog>) {
501-
for nested_col in &col.field_descs {
502-
// What's the usage of struct fields' column IDs?
503-
check_col(nested_col, i, columns);
504-
}
505-
assert!(
506-
col.column_id.get_id() == *i as i32,
507-
"unexpected column id\ncol: {col:?}\ni: {i}\ncolumns: {columns:#?}"
508-
);
509-
*i += 1;
510-
}
511-
for col in columns {
512-
check_col(&col.column_desc, &mut i, columns);
513-
}
514-
}
515-
}
516-
517495
if !format_encode_options_to_consume.is_empty() {
518496
let err_string = format!(
519497
"Get unknown format_encode_options for {:?} {:?}: {}",

0 commit comments

Comments
 (0)