Skip to content

Commit 84a7280

Browse files
committed
Rebase ament#587 on ament#598 and enable mixed msg/python tests
Signed-off-by: R Kent James <[email protected]>
1 parent 8bdf598 commit 84a7280

File tree

8 files changed

+2
-41
lines changed

8 files changed

+2
-41
lines changed

ament_cmake_python_test/test/ament_python_test_package/__init__.py

Whitespace-only changes.

ament_cmake_python_test/test/ament_python_test_package/main.py

Lines changed: 0 additions & 3 deletions
This file was deleted.

ament_cmake_python_test/test/ament_python_test_package_overlay/__init__.py

Lines changed: 0 additions & 1 deletion
This file was deleted.

ament_cmake_python_test/test/ament_python_test_package_overlay/subdir/__init__.py

Whitespace-only changes.

ament_cmake_python_test/test/ament_python_test_package_overlay/subdir/utils.py

Lines changed: 0 additions & 2 deletions
This file was deleted.

ament_cmake_python_test/test/options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
# Set True to generate both a python package and a msg package for each python package
1818
# This is useful to test that python and msg packages can coexist in the same package
1919
# See issue #514 and PR #587
20-
COMBINE_PYTHON_WITH_MSG = False
20+
COMBINE_PYTHON_WITH_MSG = True
2121

2222
# Set True to test ordering sensitivity of python and msg generation in CMakeLists.txt
2323
TEST_ORDERING_SENSITIVITY = False

ament_cmake_python_test/test/test_ament_python_install_package.py

Lines changed: 0 additions & 30 deletions
This file was deleted.

ament_cmake_python_test/test/test_packages.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
#
1515
"""Test of ament_python_install_package."""
1616

17-
# Not used until PR #587
18-
# import filecmp
17+
import filecmp
1918
import multiprocessing as mp
2019
import os
2120
from pathlib import Path
@@ -229,7 +228,6 @@ def test_from_options(module_dir):
229228
pool.terminate()
230229

231230

232-
'''Disable tests until PR #587 is merged
233231
def test_ament_python_test_package(module_dir) -> None:
234232
"""Test installing a known package and comparing to the source files."""
235233
do_build_package(AMENT_PYTHON_TEST_PACKAGE, SOURCE_DIR / 'test' / 'packages', module_dir)
@@ -290,4 +288,3 @@ def test_python_double_version(module_dir) -> None:
290288
egg_info_file = egg_info_dir / 'PKG-INFO'
291289
assert Path.read_text(egg_info_file).find(f'Version: {version}') != -1, \
292290
f'egg-info file should contain "Version: {version}"'
293-
'''

0 commit comments

Comments
 (0)