Skip to content
This repository has been archived by the owner on May 31, 2018. It is now read-only.

use makepkg utils functions #422

Open
rmarquis opened this issue Feb 14, 2016 · 3 comments
Open

use makepkg utils functions #422

rmarquis opened this issue Feb 14, 2016 · 3 comments

Comments

@rmarquis
Copy link
Owner

Now that makepkg is split in various sub libraries, it might be a good idea to use the provided utils functions instead of reimplementing an equivalent. Cleaner and less code to maintain, and this will also likely give a more makepkg-like feel too.

See /usr/share/makepkg/util/message.sh and /usr/share/makepkg/util.sh. Sourcing these files should be enough. Check and ensure translated string still work here.

@rmarquis rmarquis added the todo label Feb 14, 2016
@rmarquis rmarquis added this to the 5.x - new features milestone Feb 14, 2016
@rmarquis rmarquis modified the milestones: 4.6.x - new features, 5.0.x - later Mar 24, 2016
@AladW
Copy link
Contributor

AladW commented Mar 25, 2016

Note that message.sh lacks PURPLE (\e[1;35) and CYAN (\e[1;35). source.sh may also be useful, e.g for get_protocol.

@rmarquis rmarquis modified the milestones: 4.7.x - new features, 5.0.x - later Oct 11, 2016
@rmarquis
Copy link
Owner Author

Closing this ticket now, since I'll likely not do this by myself. Further work can be tracked in #443 where this feature has been mentioned.

@rmarquis
Copy link
Owner Author

rmarquis commented Dec 5, 2017

Reopening in light of #708.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants