Skip to content

[Enhancement] What about using DAP support from LSP4IJ #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelozerr opened this issue Mar 10, 2025 · 1 comment
Open

[Enhancement] What about using DAP support from LSP4IJ #407

angelozerr opened this issue Mar 10, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@angelozerr
Copy link

I have noticed that you have implemented custom dap support https://github.com/robotcodedev/robotcode/tree/main/intellij-client%2Fsrc%2Fmain%2Fkotlin%2Fdev%2Frobotcode%2Frobotcode4ij%2Fdebugging

As you are based on Lsp4ij to support your lsp server,I wonder (I hope) if you could be intersted to use LSP4IJ dap support https://github.com/redhat-developer/lsp4ij/blob/main/docs/dap/UserGuide.md

You can read https://github.com/redhat-developer/lsp4ij/blob/main/docs/dap/DAPSupport.md to know what lsp4ij is supporting as dap features. For instance we support completion, inline debug value etc.

Today dap support should work fine by using dap breakpoint type, dap configuration type. It should work well by declaring the dap server, the dap behaviour like stdio, socket and request launch and attach, but I have started to provide the capability to use extension point https://github.com/redhat-developer/lsp4ij/blob/main/docs/dap/DeveloperGuide.md

With this extension point you can embed in your plugin the dap server and avoid declaring some path of the dap server, and how dap client must be connected to the dap server.

I need to improve this extension point to use custom breakpoint type, use custom configuration type, custom settings editor like you have.

I will be super happy if you would like to try our dap support (with declaration mean at first) and start to implement the dap extension point.

If you could be interested, I could contine my work for dap extension point to use your custom breakpoint type. Custom configuration type, etc.

My goal is to have a generic and extensible dap support (like we have with lsp).

Hope you could be interested.

@angelozerr angelozerr added the enhancement New feature or request label Mar 10, 2025
@d-biehl
Copy link
Member

d-biehl commented Mar 17, 2025

Hey @angelozerr,

Thanks for lsp4ij and for getting in touch about DAP.
RobotCode's PyCharm/IntelliJ support is still in its early days – there's a bunch of configuration dialogs and minor details that need to be implemented. I started working on DAP support – basically as an experiment – even before you added it in lsp4ij, because I wanted something to show at [RoboCon](https://robocon.io/program#online-robotcode-10-launch-party). I'll definitely take another look at it, but right now there are other priorities (like the buggy TextMate support in the IntelliJ Platform).

I'll keep this issue open as a to-do.
Thanks again for lsp4ij!

Cheers!

@d-biehl d-biehl changed the title What about using DAP support from LSP4IJ [Enhancement] What about using DAP support from LSP4IJ Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants