Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Unify TEO link names #37

Open
2 of 5 tasks
jgvictores opened this issue Feb 15, 2018 · 13 comments
Open
2 of 5 tasks

Review and Unify TEO link names #37

jgvictores opened this issue Feb 15, 2018 · 13 comments

Comments

@jgvictores
Copy link
Member

jgvictores commented Feb 15, 2018

@jgvictores
Copy link
Member Author

Note: would like to change teo-simox-names.pdf -> teo-link-names.pdf or similar.
Must update the following current items after that:

@AlvaroMartinezR
Copy link

@jgvictores I am not sure fi you want to change the names I used in simox to other or the other way around, change the simox ones.

@jgvictores
Copy link
Member Author

Simox names are good!
Unless there is some other naming for the links, I think it would be cool to adopt the ones you have on the PDF everywhere (thus could drop the simox from name, as becomes generic info).

@AlvaroMartinezR
Copy link

Ok, now I understand. I know that the ones used in openrave are something like r10.001.

@jgvictores
Copy link
Member Author

Will probably be renaming and moving things around today, have presentation on TEO tomorrow evening! :-)

jgvictores added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue Mar 15, 2018
@jgvictores jgvictores added complexity: hard complexity: tedious Tarea tediosa que nadie quiere hacer and removed complexity: hard labels Dec 12, 2018
@jgvictores jgvictores added the blocked Do not focus on this issue until blocking issue is closed label Apr 30, 2019
@PeterBowman
Copy link
Member

PeterBowman commented Jun 26, 2019

Note: "saggital, frontal, axial..." might be misplaced, e.g. current saggital leg links are actually frontal links according to https://en.wikipedia.org/wiki/Anatomical_plane.

@jgvictores jgvictores removed the blocked Do not focus on this issue until blocking issue is closed label Jun 28, 2019
@imontesino imontesino pinned this issue Sep 26, 2019
@PeterBowman
Copy link
Member

Note: review and unify OpenRAVE link names, too.

@jgvictores
Copy link
Member Author

Note: review and unify OpenRAVE joint names, too.

Updated issue description. May have added some overkill: for now our .ini's do not contain this sort of info.

@jgvictores
Copy link
Member Author

ASWB, we'll name links as previous joints, in a DH fashion.

@rsantos88
Copy link
Contributor

In order to help with this issue, and to be sure that I've understood it, do you want to replace, for example q10 here by FrontalRightShoulder or by the label FRS15 following this table? Is it right?

@jgvictores
Copy link
Member Author

jgvictores commented Nov 9, 2019

Hi! The table is the correct one, and we'd use the first column, e.g. FrontalRightShoulder as you said.

However, q10 would be a joint, to be done at #44. <- We can start with this issue first! 😄

This issue refers to links, with names such as r10. This can be slightly more tedious. Things to be taken into account:

@jgvictores
Copy link
Member Author

Regarding the OpenRAVE model, since roboticslab-uc3m/teo-openrave-models#35 has been merged, I guess this could be done (warning! pretty tedious ^^).

jgvictores added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue Nov 13, 2019
jgvictores added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue Nov 13, 2019
renamed link names according to Unified TEO link names [ @rsantos88 THANKS! ]

- roboticslab-uc3m/teo-main#37
jgvictores added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants